Roundup Robot added the comment:
New changeset a90c6d608b85 by Robert Collins in branch '3.4':
Issue #21112: Fix regression in unittest.expectedFailure on subclasses.
https://hg.python.org/cpython/rev/a90c6d608b85
New changeset ac3f1a6b1de2 by Robert Collins in branch '3.5':
Issue #21112: Fix
Robert Collins added the comment:
2.7 is sufficiently different that I haven't backported this there - plus the
report said it was introduced in 3.4. If someone can show this doesn't work in
2.7 and also supply a patch, we could apply it there.
--
Changes by Robert Collins robe...@robertcollins.net:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
Changes by Robert Collins robe...@robertcollins.net:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
Robert Collins added the comment:
Test looks good to me. Do you want to apply it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
___
William Schwartz added the comment:
3.4.3 has been released, it seems, without this getting fixed.
3.4.4 then?
--
William Schwartz
On Mon, Sep 8, 2014 at 3:42 AM, Michael Foord rep...@bugs.python.org
wrote:
Michael Foord added the comment:
The patch looks good to me.
--
Antoine Pitrou added the comment:
Berker, it looks like the 3.3 behaviour was buggy: TestTreatment isn't run at
all! Instead, it should be run and consider failures as success.
So your patch appears more correct than what 3.3 did.
--
___
Python
William Schwartz added the comment:
3.4.2 has been released, it seems, without this getting fixed.
3.4.3 then? Are we still happy with the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
Berker Peksag added the comment:
3.4.3 then? Are we still happy with the patch?
Please see msg218727. The patch is not ready yet.
--
nosy: +rbcollins
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
Michael Foord added the comment:
The patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
___
Python-bugs-list
Ned Deily added the comment:
Should this be fixed for 3.4.2?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
___
Python-bugs-list
Larry Hastings added the comment:
Note: current plan for 3.4.2 is to release at the end of the month. RC1 will
be in about a week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
Berker Peksag added the comment:
Berker: do you consider your diff ready to go in, or is it an early
diff (like a work-in-progress)?
I tested my patch with test_expectedFailure.py again. The patch is not really
fixes the problem described in msg215240. So, I consider it a WIP patch for
now.
Larry Hastings added the comment:
Considering that I'm tagging 3.4.1 within an hour or two, and we don't have a
patch yet, I'd say that this is too late to go into 3.4.1. But I'm happy to
consider it for a future 3.4.x revision.
--
___
Python
Changes by Ned Deily n...@acm.org:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
Berker: do you consider your diff ready to go in, or is it an early diff
(like a work-in-progress)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
Berker Peksag added the comment:
Is there a chance to get this into 3.4.1?
--
stage: - patch review
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
___
Ned Deily added the comment:
Berker, if you think it should go into 3.4.1, you need to set the priority to
release blocker to bring it to the attention of the release manager.
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
New submission from William Schwartz:
In Python 2.7 and 3.3, decorating a unittest.TestCase subclass with
unittest.expectedFailure caused test discover to skip the decorated test case.
Python 3.4 apparently ignores the decorator when applied to classes.
The attached file when run with Python
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
components: +Tests
keywords: +3.4regression
nosy: +ezio.melotti, michael.foord, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
Changes by Berker Peksag berker.pek...@gmail.com:
--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file34681/issue21112.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21112
22 matches
Mail list logo
