[issue2122] mmap.flush does not check for errors on windows

Berker Peksag added the comment: Thanks for the suggestions and for the reviews! -- assignee: brian.curtin -> priority: high -> normal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue2122] mmap.flush does not check for errors on windows

Berker Peksag added the comment: New changeset e7d4b2f205c711d056bea73a0093e2e2b200544b by Berker Peksag in branch 'master': bpo-2122: Make mmap.flush() behave same on all platforms (GH-8692) https://github.com/python/cpython/commit/e7d4b2f205c711d056bea73a0093e2e2b200544b -- nosy:

[issue2122] mmap.flush does not check for errors on windows

Steve Dower added the comment: I agree. We should definitely document it as a change, but I don't think there's anything useful you can do in the case of a flush failing anyway, so it seems unlikely that anyone could depend on the return value. Returning None for success and exception on

[issue2122] mmap.flush does not check for errors on windows

Serhiy Storchaka added the comment: If we break compatibility in any case, what if return None instead of 0? The function always returning 0 looks strange. The function always returning None is common. -- nosy: +serhiy.storchaka versions: +Python 3.8 -Python 2.7, Python 3.4, Python

[issue2122] mmap.flush does not check for errors on windows

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2122] mmap.flush does not check for errors on windows

Change by Berker Peksag : -- pull_requests: +8187 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2122] mmap.flush does not check for errors on windows

Changes by Brian Curtin br...@python.org: -- nosy: -brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___ Python-bugs-list

[issue2122] mmap.flush does not check for errors on windows

Mark Lawrence added the comment: I think we should be properly handling errors. If people agree I'll provide a new patch to cover code and doc changes, but I've no idea how to provide any form of unit test for the change. -- nosy: +BreamoreBoy, paul.moore, steve.dower, zach.ware

[issue2122] mmap.flush does not check for errors on windows

Changes by Atsuo Ishimoto ishim...@gembook.org: -- nosy: +ishimoto ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___ Python-bugs-list

[issue2122] mmap.flush does not check for errors on windows

Changes by Antoine Pitrou pit...@free.fr: -- stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___

[issue2122] mmap.flush does not check for errors on windows

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___

[issue2122] mmap.flush does not check for errors on windows

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: This issue seems to be reproduced in following way. 1. Attach USB flash drive. (On my machine, it was attached as E drive) 2. Run python interactive shell and run following commands. (Confirmed on Python2.6) import mmap

[issue2122] mmap.flush does not check for errors on windows

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +brian.curtin, tim.golden versions: -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___

[issue2122] mmap.flush does not check for errors on windows

Changes by Brian Curtin cur...@acm.org: -- assignee: - brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___ Python-bugs-list

[issue2122] mmap.flush does not check for errors on windows

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___

[issue2122] mmap.flush does not check for errors on windows

Changes by Daniel Diniz aja...@gmail.com: -- priority: - high stage: - test needed versions: +Python 3.1 -Python 2.5, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___

[issue2122] mmap.flush does not check for errors on windows

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +ocean-city ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2122 ___ ___ Python-bugs-list mailing

[issue2122] mmap.flush does not check for errors on windows

Ralf Schmitt [EMAIL PROTECTED] added the comment: now this insanity is even documented with svn revision 62359 (http://hgpy.de/py/trunk/rev/442252bce780) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2122 __

[issue2122] mmap.flush does not check for errors on windows

Antoine Pitrou [EMAIL PROTECTED] added the comment: Perhaps it would be better if the patch came with unit tests. I agree that the situation right now is insane. PS : I have no power to commit or even accept a patch :) -- nosy: +pitrou __ Tracker [EMAIL

[issue2122] mmap.flush does not check for errors on windows

Ralf Schmitt [EMAIL PROTECTED] added the comment: I thought about this too, but I don't know of a way to provoke an error. (Other than passing in illegal values, but the code tries to catch those. And btw, raises an Exception on windows :) One could currently pass in a negative value for size

[issue2122] mmap.flush does not check for errors on windows

Changes by Martin v. Löwis [EMAIL PROTECTED]: -- keywords: +patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2122 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2122] mmap.flush does not check for errors on windows

Ralf Schmitt [EMAIL PROTECTED] added the comment: attached is a patch. I hope it is ok to change the semantics a bit. They were very strange: - on unix it raises an exception on errors. otherwise it always returns 0. - on windows it returns non-zero on success, and returns zero on errors. Now,

[issue2122] mmap.flush does not check for errors on windows

New submission from Ralf Schmitt: mmap.flush returns the result of the call to FlushViewOfFile as an integer, and does not check for errors. On unix it does check for errors. The function should return None and raise an exception if an error occurs... This bug can lead to data loss... Here's