Roundup Robot added the comment:
New changeset 706ec07100d6 by Victor Stinner in branch '3.4':
Issue #21440: Backport changeset 4ebf97299b18 to branch 3.4, use
http://hg.python.org/cpython/rev/706ec07100d6
New changeset 6b4d31641109 by Victor Stinner in branch '3.4':
Issue #21440: test_zipfile:
Roundup Robot added the comment:
New changeset 4ebf97299b18 by Tim Golden in branch 'default':
Issue21440 Use support.rmtree in test_zipfile test_tarfile
http://hg.python.org/cpython/rev/4ebf97299b18
--
nosy: +python-dev
___
Python tracker rep
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
New submission from Tim Golden:
At present test_zipfile uses shutil.rmtree to remove its test artefacts. This
intermittently but frequently fails to remove cleanly on a Windows development
box. Changing it to use the test.support helper functions should reduce the
incidence.
--
Changes by Tim Golden m...@timgolden.me.uk:
--
keywords: +patch
Added file: http://bugs.python.org/file35156/issue21440.test_zipfile.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Same goes for test_tarfile (updated patch attached)
--
Added file: http://bugs.python.org/file35157/issue21440.test_tarzipfile.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
Tim Golden added the comment:
Adding Zach as another Windows dev
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Zachary Ware added the comment:
I don't see the intermittent failures (this machine may well just be too slow).
The patch looks good and doesn't cause failures, though, so +1 from me.
--
___
Python tracker rep...@bugs.python.org
Tim Golden added the comment:
Thanks. I get them enough that it stops a test run being particularly
useful, especially when I've just touched something (eg unlink) which
might conceivably affect something like tarfile.
--
___
Python tracker
