[issue21446] Update reload fixer to use importlib instead of imp

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue21446] Update reload fixer to use importlib instead of imp

Berker Peksag added the comment: New changeset 05a72f15f76301c505a91728f0818b421fddd290 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-21446: Update reload fixer to use importlib (GH-8391) https://github.com/python/cpython/commit/05a72f15f76301c505a91728f0818b421fddd290

[issue21446] Update reload fixer to use importlib instead of imp

Change by miss-islington : -- pull_requests: +7930 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21446] Update reload fixer to use importlib instead of imp

Berker Peksag added the comment: New changeset 7a3056fa7dd1223fe7112e53b236c43d71f33f64 by Berker Peksag in branch 'master': bpo-21446: Update reload fixer to use importlib (GH-8391) https://github.com/python/cpython/commit/7a3056fa7dd1223fe7112e53b236c43d71f33f64 --

[issue21446] Update reload fixer to use importlib instead of imp

Change by Berker Peksag : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21446] Update reload fixer to use importlib instead of imp

Brett Cannon added the comment: I think we said backporting fixers was fine but I honestly don't remember. On Sat, Jul 21, 2018, 23:22 Berker Peksag, wrote: > > Berker Peksag added the comment: > > Thanks, Brett. I've opened PR 8391. Should we backport this to 3.7? We do > backport

[issue21446] Update reload fixer to use importlib instead of imp

Berker Peksag added the comment: Thanks, Brett. I've opened PR 8391. Should we backport this to 3.7? We do backport mimetypes additions (see https://github.com/python/cpython/commit/8204b903683f9e0f037ccfaa87622716019914d7 for an example) I think lib2to3 falls into the same category as

[issue21446] Update reload fixer to use importlib instead of imp

Change by Berker Peksag : -- pull_requests: +7919 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21446] Update reload fixer to use importlib instead of imp

Brett Cannon added the comment: I would still fix it as I suspect there will be a burst of users of this come 2020 and at this point it won't be a compatibility issue going forward since 3.4 is so old. :) -- ___ Python tracker

[issue21446] Update reload fixer to use importlib instead of imp

Berker Peksag added the comment: Brett, what do you think about this issue since Python 3.4 is pretty old now. Should I convert my patch to GitHub PR or close this issue as 'wontfix'? -- type: -> enhancement versions: +Python 3.8 -Python 3.5 ___

[issue21446] Update reload fixer to use importlib instead of imp

Jelle Zijlstra added the comment: I couldn't find references in the docs to clarify what version of 3.x 2to3 targets, but it seems reasonable to me that it produces code targeted to the version of CPython it was bundled with. imp is deprecated and presumably will be removed later in 3.x, so

[issue21446] Update reload fixer to use importlib instead of imp

New submission from Berker Peksag: Since imp.reload() was deprecated in issue 18193, the reload fixer (added in issue 11797) needs to be updated to use importlib.reload() instead of imp.reload(). -- components: 2to3 (2.x to 3.x conversion tool) files: reload-fixer.diff keywords: patch

[issue21446] Update reload fixer to use importlib instead of imp

Brett Cannon added the comment: I don't think that's necessarily obvious since that will make your code tied to Python 3.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21446 ___