R. David Murray added the comment:
Issue number was mistyped in commit message. Commit was 730eeb10cd81.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21467
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: test needed - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21467
___
___
New submission from Steve Dower:
#20406 changed the icon used by IDLE, but forgot to include the new file in the
Windows installer. As a result, IDLE won't start.
I've attached a patch. 3.4 is unaffected, probably because msi.py changed
significantly at some point.
(I don't have commit
Martin v. Löwis added the comment:
I'll declare this release-critical for the moment; I'm sure Benjamin will
properly process it. As for getting access: send your ssh key to
hgaccou...@python.org.
--
priority: normal - release blocker
___
Python
Tim Golden added the comment:
Steve -- re changes to PCBuild c.: worth liaising with Zach Ware (and, to a
lesser extent, me) as he's been working through a number of things in that area
and I know has other ideas.
Just post a patch and nosy us both (zach.ware / tim.golden)
Obviously, if it's
Steve Dower added the comment:
Martin - sent. I think I need some bits flipped on my account here too.
Will/can you take care of that for me?
Tim - thanks. My next task was to figure out who else has an interest in this
area. I wasn't sure if the 'windows' tag was accurate, but sounds like it
Terry J. Reedy added the comment:
Creating issues with patches, so others can comment, is a good idea even when
you have commit rights. Adding yourself to
https://docs.python.org/devguide/experts.html#experts
is a good way to test new commit rights.
--
Terry J. Reedy added the comment:
Steve, I am *really* glad you caught this. We obviously need a new test
somewhere that would have caught this before the release. How is the installer
tested now? Is it run and the installed python tested with the test suite? If
so, a new idle test that runs
Benjamin Peterson added the comment:
Yes, by all means, commit it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21467
___
___
Python-bugs-list
Steve Dower added the comment:
Currently it's an entirely manual process, which is something I intend to work
on for 3.5 and beyond. As far as post-mortem on this issue goes, Martin would
have found it as well, since I was doing exactly what he said he normally does.
The real fix seems to
Steve Dower added the comment:
Yes, by all means, commit it.
Obviously I spent too long writing my last comment :)
Pushed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21467
___
Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21467
___
12 matches
Mail list logo
