[issue21526] Support new booleans in Tkinter

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21526] Support new booleans in Tkinter

Roundup Robot added the comment: New changeset 77e5623e22dd by Serhiy Storchaka in branch '2.7': Issue #21526: Skip test_booleans on Tcl < 8.5. https://hg.python.org/cpython/rev/77e5623e22dd New changeset 3b8039c37b37 by Serhiy Storchaka in branch '3.4': Issue #21526: Skip test_booleans on Tcl <

[issue21526] Support new booleans in Tkinter

STINNER Victor added the comment: http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/9465/steps/test/logs/stdio == FAIL: test_booleans (test.test_tcl.TclTest) ---

[issue21526] Support new booleans in Tkinter

Roundup Robot added the comment: New changeset 954e7e1d85f1 by Serhiy Storchaka in branch '2.7': Issue #21526: Fixed the test_booleans test for wantobjects = 0. https://hg.python.org/cpython/rev/954e7e1d85f1 New changeset 4255ca2f5314 by Serhiy Storchaka in branch '3.4': Issue #21526: Fixed the

[issue21526] Support new booleans in Tkinter

Serhiy Storchaka added the comment: And indeed, "app->BooleanType" is NULL, because the "booleanString" type is not registered in Tcl. Thank you for pointing on it Amaury. Now it is fixed. -- status: open -> closed ___ Python tracker

[issue21526] Support new booleans in Tkinter

Roundup Robot added the comment: New changeset de3496cd609e by Serhiy Storchaka in branch '3.4': Issue #21526: Tkinter now supports new boolean type in Tcl 8.5. https://hg.python.org/cpython/rev/de3496cd609e New changeset b2413da7516f by Serhiy Storchaka in branch 'default': Issue #21526: Fixed

[issue21526] Support new booleans in Tkinter

Changes by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue21526] Support new booleans in Tkinter

Serhiy Storchaka added the comment: When I said this, I understood that the patch should be backported to maintained releases. Unpatched Python with Tcl 8.5: >>> import tkinter; tcl = tkinter.Tcl() >>> tcl.call('expr', 'false') >>> bool(tcl.call('expr', 'false')) True -- ___

[issue21526] Support new booleans in Tkinter

Amaury Forgeot d'Arc added the comment: Ah, the NULL case is indeed tested just above. So the current code works correctly. -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue21526] Support new booleans in Tkinter

Serhiy Storchaka added the comment: The case (value->typePtr == NULL) is tested above for purpose, so it is not a bug when one of type pointers is NULL. "booleanString" was added in 8.5, replacing "boolean", but in 8.6 it is not used. All boolean values in 8.6 are just integers 0 and 1. -

[issue21526] Support new booleans in Tkinter

Amaury Forgeot d'Arc added the comment: I'm not sure that this change is correct. I have Tcl version 8.6 installed, and I checked that "app->BooleanType" is NULL. Fortunately value->typePtr is probably never NULL, but I think the comparison should be skipped in this case. Where did you see thi

[issue21526] Support new booleans in Tkinter

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue21526] Support new booleans in Tkinter

Roundup Robot added the comment: New changeset e9d86c1de292 by Serhiy Storchaka in branch 'default': Issue #21526: Tkinter now supports new boolean type in Tcl 8.5. https://hg.python.org/cpython/rev/e9d86c1de292 -- nosy: +python-dev ___ Python tracker

[issue21526] Support new booleans in Tkinter

New submission from Serhiy Storchaka: Recent Tcl versions (since 8.5) no longer use internal "boolean" type. Instead they use "booleanString" type (but looks as only internally). Here is a patch which add support for "booleanString" Tcl type in case when it leaks to user. There are no any new