[issue2153] unittest.py modernization

2008-12-28 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Will take a look. -- versions: +Python 2.7 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2153 ___

[issue2153] unittest.py modernization

2008-12-28 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Committed in r67985, thanks! -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2153 ___

[issue2153] unittest.py modernization

2008-08-08 Thread Virgil Dupras
Virgil Dupras [EMAIL PROTECTED] added the comment: This patch has gone invalid due to some recent conflicting changes. I remade it and I'm resubmitting it hoping that it will get applied. Added file: http://bugs.python.org/file11086/unittest_modern2.diff

[issue2153] unittest.py modernization

2008-02-21 Thread Virgil Dupras
New submission from Virgil Dupras: What prompted me to do these changes is that Backward compatibility section for 2.1 and earlier. How long are we going to keep this? According to svn, no commit has been made on the 2.1 branch since 2003. Is it safe to assume no unittest change is ever going

[issue2153] unittest.py modernization

2008-02-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: À propos modernizing unittest, may I suggest taking a look at #1034053. :) -- nosy: +pitrou __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153 __

[issue2153] unittest.py modernization

2008-02-21 Thread Benjamin Peterson
Changes by Benjamin Peterson: -- nosy: +purcell __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2153] unittest.py modernization

2008-02-21 Thread Steve Purcell
Steve Purcell added the comment: Hi Virgil; thanks for stepping up to this. Backward compatibility was largely for the sake of compatibility with Jython, which was always lagging far behind CPython. I doubt it's a concern these days, and the unittest.py in the Python source repository

[issue2153] unittest.py modernization

2008-02-21 Thread Virgil Dupras
Virgil Dupras added the comment: Isn't it why KeyboardInterrupt is a subclass of BaseException instead of Exception (along with SystemExit)? so that except Exception: doesn't catch it? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153

[issue2153] unittest.py modernization

2008-02-21 Thread Christian Heimes
Christian Heimes added the comment: All changes are looking fine to me but I haven't looked at the patch so far. __metaclass__ = type is easier to write than subclassing from object. Both are equivalent. __metaclass__ = type class Foo: pass ... Foo class '__main__.Foo' Foo.__bases__ (type

[issue2153] unittest.py modernization

2008-02-21 Thread Steve Purcell
Steve Purcell added the comment: Yes indeed - you're exactly right; just checked now. Then disregard my previous comment! __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153 __

[issue2153] unittest.py modernization

2008-02-21 Thread Christian Heimes
Changes by Christian Heimes: -- keywords: +patch priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2153 __ ___ Python-bugs-list mailing list