[issue2168] gdbm needs to be iterable

2008-02-25 Thread Facundo Batista
Facundo Batista added the comment: Applied in r61072. Raymond, I stole this from you, because I had the same conclusion and it was very needed for the buildbot. Thank you all! -- nosy: +facundobatista resolution: - accepted status: open - closed __

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thx. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2168 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2168] gdbm needs to be iterable

2008-02-24 Thread Thomas Herve
Changes by Thomas Herve: -- keywords: +patch Added file: http://bugs.python.org/file9531/dbm.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2168 __ ___

[issue2168] gdbm needs to be iterable

2008-02-24 Thread Thomas Herve
Changes by Thomas Herve: Added file: http://bugs.python.org/file9532/gdbm.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2168 __ ___ Python-bugs-list mailing list

[issue2168] gdbm needs to be iterable

2008-02-24 Thread Thomas Herve
Thomas Herve added the comment: Attached files add contains method to dbm and gdbm objects. It fixes failures with test_shelve. I'm ready to add more tests for this, but #1960 should probably go in first (it converts the tests to unittest, and add some coverage). Please review!

[issue2168] gdbm needs to be iterable

2008-02-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: The patch looks good to my eye, but I can't test it directly. Will apply and see what the buildbots think about it. -- nosy: +rhettinger priority: - high __ Tracker [EMAIL PROTECTED]

[issue2168] gdbm needs to be iterable

2008-02-24 Thread Raymond Hettinger
Changes by Raymond Hettinger: -- assignee: - rhettinger __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2168 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2168] gdbm needs to be iterable

2008-02-23 Thread Thomas Herve
New submission from Thomas Herve: A recent change in shelve (r60927) raises the need for gdbm objects to be iterable. We can see it by running test_shelve on a machine with gdbm. I'll try to fix this. The same thing should be done with the dbm module I think. -- components: Library