[issue21697] shutil.copytree() handles symbolic directory incorrectly

Roundup Robot added the comment: New changeset e807f1d81cb6 by Berker Peksag in branch '3.4': Issue #21697: shutil.copytree() now correctly handles symbolic links that point to directories. https://hg.python.org/cpython/rev/e807f1d81cb6 New changeset 31f4041b9286 by Berker Peksag in branch

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Berker Peksag added the comment: Thanks for the patches and testing! -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21697

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Changes by Berker Peksag berker.pek...@gmail.com: -- assignee: - berker.peksag nosy: +takluyver versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21697 ___

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Thomas Kluyver added the comment: Here's my patch (I submitted the duplicate issue). I think it's functionally the same as Eduardo's, but it also adds a test. -- Added file: http://bugs.python.org/file39893/shutil_copytree_symlink_dir.patch ___

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Björn Dahlgren added the comment: I ran across this bug too. Applying Eduardo's patch got my package working under Py 3.4 -- nosy: +Björn.Dahlgren ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21697

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Daniel Eriksson added the comment: I have tested both patches on CentOS 6.4 and Eduardo Seabra:s patch works correctly with symlinks=True -- nosy: +dan...@starstable.com ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21697

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Eduardo Seabra added the comment: Berker Peksag, I don't think your patch is okay. When symlinks is set to true, it should copy the symbolic link of the directory. Your code is calling copytree instead. I think the following patch is working, no errors on regression tests. -- nosy:

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Berker Peksag added the comment: Here's a patch. I'm getting the following error without modify Lib/shutil.py: == ERROR: test_copytree_symbolic_directory (test.test_shutil.TestShutil)

[issue21697] shutil.copytree() handles symbolic directory incorrectly

New submission from Shajunxing: While using shutil.copytree() and the source containing symbolic directory (not symbolic file), an error will be raised. I checked the source code and found an obvlous mistake: shutil.copytree() using os.path.islink() to checker whether the source is a symbolic

[issue21697] shutil.copytree() handles symbolic directory incorrectly

Ned Deily added the comment: Thanks for the report. The bug is still present in the 3.4 and default (what will become the 3.5 release) branches; the 3.3 branch now only accepts security fixes. 2.7 does not fail. Would you be interested in producing a patch for the problem? --