Roundup Robot added the comment:
New changeset 833325d45113 by Victor Stinner in branch '3.4':
Issue #21813: Enhance documentation of the os.stat_result class.
http://hg.python.org/cpython/rev/833325d45113
New changeset 5d70ac83d104 by Victor Stinner in branch 'default':
Issue #21813: Enhance
STINNER Victor added the comment:
Thanks Zachary Ware for your review. I'm not sure that I addressed all your
comments, but I'm not interested to spend too much time on the documentation.
Please open an issue if your saw other things that can be improved.
--
resolution: - fixed
Zachary Ware added the comment:
The only comments you didn't address you were right not to (sorry for the noise
about path_fd, I completely missed that it was just a link reference); what you
committed looks fine to me.
Thanks for your work on this, it looks like a big improvement to me!
New submission from STINNER Victor:
Attached patch creates a stat_result class in the os documentation and complete
the documentation of each field. It makes possible to link directly an
attribute of this class in the documentation, which is useful for the new
st_file_attributes (issue
Zachary Ware added the comment:
Rietveld didn't like an escape code at the beginning of your patch; here's the
last 12,039 bytes of it which will hopefully make Rietveld happy.
--
nosy: +zach.ware
Added file: http://bugs.python.org/file35705/stat_result.patch
STINNER Victor added the comment:
...an escape code at the beginning of your patch...
Yeah, these days I suffer because of the issue #19884 (readline issue in
Mercurial).
--
___
Python tracker rep...@bugs.python.org
