[issue21815] imaplib truncates some untagged responses

Roundup Robot added the comment: New changeset 54b36229021a by R David Murray in branch 'default': #21815: violate IMAP RFC to be compatible with, e.g., gmail https://hg.python.org/cpython/rev/54b36229021a -- nosy: +python-dev ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Roundup Robot added the comment: New changeset 53271aa4d84c by R David Murray in branch 'default': #21815: Make the doc change match what I actually did. https://hg.python.org/cpython/rev/53271aa4d84c -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Changes by R. David Murray : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue21815] imaplib truncates some untagged responses

R. David Murray added the comment: I rewrote the comments, and I changed the name of the test helper class from GmailHandler to BracketFlagHandler, since this is not gmail specific. (There was a review comment about that that was missed, I guess). I've applied this only to 3.6 because there

[issue21815] imaplib truncates some untagged responses

R. David Murray added the comment: When you think a patch is ready for commit, you can move it to commit review, which will put it in my queue (not that I've been getting to that very fast lately, but I'm going to try to be better about it...) --

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: I've checked the patch: it looks good, applies cleanly to latest default and passes all the tests. I'm ok with merging this as is. -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Sounds good. On Tuesday, December 22, 2015, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Lita can you please apply the changes from latest review (from > SilentGhost). Especially the one regarding newline, which currently

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Lita can you please apply the changes from latest review (from SilentGhost). Especially the one regarding newline, which currently fails to apply this patch on default. If all those will be cleaned I'll recommend this patch for David for inclusion. --

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is a patch after SlientGhost's review. I have added back the newline and included the comments for the imaplib documentation. -- Added file: http://bugs.python.org/file41395/imaplib_after_silentghost_review.patch

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Applied the changes that berkerpeksag made. Please review, and let me know if further changes need to be made. -- Added file: http://bugs.python.org/file41366/imaplib_after_review.patch ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Lita if you still have problems or want to ask questions reach out to me on IRC, I'm soltysh on freenode. -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Had some trouble setting up my dev environment for Python. Definitely going to work on it today and tomorrow. On Tue, Dec 8, 2015 at 12:33 PM, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Perfect, thanks! > > -- > >

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: I apologize, I completely forgot. I will do it this week. Thanks for the reminder! -- ___ Python tracker ___

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Perfect, thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Hey Lita, final call ;) Can you address berkerpeksag comments from review? Otherwise, I'm planning to take ownership of this issue and resubmit your patch with addressed comments. -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Hi Maciej, I am not seeing berkerpeksag review...? What was his comment? I apologize, but I haven't used the bug tracker in awhile. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815

[issue21815] imaplib truncates some untagged responses

Berker Peksag added the comment: Hi Lita, my review comments are at http://bugs.python.org/review/21815/ (sorry, I forgot to add a comment here after I made the review) -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Lita always look for them next to your uploaded file, there's a review link that points to Rietveld Code Review Tool. There you'll find all those information, just for future use :) -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Lita thanks for your patch!. Are you able to address berkerpeksag comments from review? Otherwise if you don't mind I'll take it over and I'll do that. -- nosy: +maciej.szulik ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is the patch merged together. I apologize for not getting it to you sooner. -- Added file: http://bugs.python.org/file37245/imaplib_bracket_fix.patch ___ Python tracker rep...@bugs.python.org

[issue21815] imaplib truncates some untagged responses

Changes by Berker Peksag berker.pek...@gmail.com: -- versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___ ___

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Sure, let me combine it into one change. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___ ___

[issue21815] imaplib truncates some untagged responses

Ezio Melotti added the comment: Thanks for the patches Lita, however it's better if you can upload a single patch with all the required changes. This will make it easier to apply/review it. -- stage: test needed - patch review ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: pinging for another review. I have included tests for the patch as well as documentation! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___

[issue21815] imaplib truncates some untagged responses

R. David Murray added the comment: Just to make sure I understand: the issue is that gmail may produce flags with [] in them, and imaplib currently fails to process such flags when it receives them from gmail? In principle I think we would not want to allow imaplib to be used to create

[issue21815] imaplib truncates some untagged responses

Rafał Stożek added the comment: Yeah, basically. The flags with [] characters are added to gmail (in my case) by OtherInbox's Organizer app. I contacted them but haven't heard back yet. On Wed, Jul 16, 2014 at 4:07 PM, R. David Murray rep...@bugs.python.org wrote: R. David Murray added the

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: R. David Murray added the comment: Just to make sure I understand: the issue is that gmail may produce flags with [] in them, and imaplib currently fails to process such flags when it receives them from gmail? This is correct. Gmail allows you to create flags

[issue21815] imaplib truncates some untagged responses

R. David Murray added the comment: Postel's Law says: be conservative in what you do, be liberal in what you accept from others. So the client should not violate the RFC when sending data to the server. The server, on the other hand, by that law could accept dirty data if it can do

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Okay, sounds good. I will also create a patch in the documentation that explains this, as well as comment on the regex patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is a patch for test_imaplib.py, adding the test for brackets. It should fail with the current version of imaplib, but should pass with the imap_regex.patch. -- Added file: http://bugs.python.org/file35977/test_imaplib.patch

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Updated the documentation in imaplib.rst to describe the RFC violation. -- versions: -Python 3.4, Python 3.5 Added file: http://bugs.python.org/file35978/imap_doc.patch ___ Python tracker rep...@bugs.python.org

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Updated my regex patch to include a comment about how we are violating the RFC and allowing all characters rather thane excluding the ] character. -- Added file: http://bugs.python.org/file35979/imap_regex.patch ___

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: I have a patch for this. With my patch, the debug output is fixed. -- keywords: +patch Added file: http://bugs.python.org/file35962/imap_regex.patch ___ Python tracker rep...@bugs.python.org

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is a log of the output. -- Added file: http://bugs.python.org/file35963/imaplib_log_with_patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___

[issue21815] imaplib truncates some untagged responses

Jessica McKellar added the comment: Thanks for the patch, Lita! Lita: I have some patch feedback for you at the end of this message. -- Lita and I talked about this a bit via email; here's some additional context from that conversation: There were a couple of questions to answer before

[issue21815] imaplib truncates some untagged responses

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Yes! I agree, this change will need tests. I will start working on creating those now. Here is test I did to create a flag with brackets. import imaplib mail = imaplib.IMAP4_SSL('imap.gmail.com') mail.login('usern...@gmail.com', 'password') # Enter your login here

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is the code in order to see the bug. imaplib.Debug = 5 mail = imaplib.IMAP4_SSL('imap.gmail.com') mail.login(username, password) # Enter your login here mail.select('test') -- ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Changes by Lita Cho lita@gmail.com: -- nosy: +Lita.Cho, jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___ ___ Python-bugs-list

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: I was reading the RFC spec, and it looks like it doesn't specificy '[' and ']' are not allowed in the PERNANENTFLAGS names. I can try to add a fix for this. But if anyone else knows if you are not allowed to have '[' or ']' in flag names, please let me know.

[issue21815] imaplib truncates some untagged responses

Changes by R. David Murray rdmur...@bitdance.com: -- components: +email nosy: +barry, r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___

[issue21815] imaplib truncates some untagged responses

New submission from Rafał Stożek: The regexp in Response_code checks for the existence of [] characters. The problem is that the strings may contain [] characters. I attach debug log which shows the data received from server and what the python extracted from it. You can see that the

[issue21815] imaplib truncates some untagged responses

Rafał Stożek added the comment: Oops, forgot the file. -- Added file: http://bugs.python.org/file35706/imaplib_log.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21815 ___