R. David Murray added the comment:
Heh, I thought it was closed. I guess my eyes were distracted by the 'fixed'
resolution.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Serhiy Storchaka added the comment:
Thank you David, all LGTM.
I noted that the :func: role sometimes is used for methods in the whatsnew file
(and perhaps in other rst files). Perhaps it should be changed to :meth:. But
this is other issue.
--
Demian Brecht added the comment:
Set as closed, assuming there's no reason to keep this issue open.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Serhiy Storchaka added the comment:
Did you noticed my comments on Rietveld about setdefault() and the :meth: role?
--
assignee: serhiy.storchaka - r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
R. David Murray added the comment:
No, sorry, I currently don't always notice reviews unless they are mentioned on
the tracker. I will take a look.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Demian Brecht added the comment:
Thanks for following up on this David. The changes you've made all look good to
me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Roundup Robot added the comment:
New changeset a70ca6f35327 by R David Murray in branch 'default':
#2211: Fix typo, address missed review comment.
https://hg.python.org/cpython/rev/a70ca6f35327
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Serhiy: I had already dealt with all the comments in my revisions in one way or
another, except for the one about setdefault. I've added documentation for
that now, too. Sorry for not posting everything for review first...if you see
anything you object to
Roundup Robot added the comment:
New changeset 09f22b5d6cea by R David Murray in branch 'default':
#2211: properly document the Morsel behavior changes.
https://hg.python.org/cpython/rev/09f22b5d6cea
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
I made several changes to the patch.
The whatsnew docs didn't format correctly: there's an extra space on all the
lines after the first (a three space indent is apparently required there which
I don't understand, but it is also our standard for docs). Also
R. David Murray added the comment:
Now, anyone want to place bets on someone getting bitten by the new errors that
update will raise? :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Demian Brecht added the comment:
it would be better to consolidate the three adjacent versionchanged entries
into one
I created the three versionchanged items because there's no visual distinction
between the second and third lines and the rest of the doc tests in the
rendered output. I've
Demian Brecht added the comment:
FWIW, I created #23778 to address the indentation issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
R. David Murray added the comment:
The body of the versionchanged has to be a single paragraph (no blank lines).
Usually we start each sentence on a newline in the source, but it comes out
rendered as a single flowed paragraph. Perhaps eventually someone will add
support to Sphinx for
Berker Peksag added the comment:
I think David's suggestion in msg239260 was good enough for now :) You'll need
to create a custom versionchanged directive to generate a valid and semantic
markup for the usage in http_cookies_morsel_deprecated_set_2.patch. I also left
a couple comments on
Demian Brecht added the comment:
Problem (pretty much) solved. Nested unordered lists are supported. I've
updated the versionchanged information to use the list.
--
Added file:
http://bugs.python.org/file38690/http_cookies_morsel_deprecated_set_2.patch
Demian Brecht added the comment:
Updated patch should address review comments. I did run with David's suggestion
as I also noticed that my initial assessment was wrong (thanks for the
note/review Berker).
--
Added file:
R. David Murray added the comment:
It looks like both of those changes were part of the python3 transition, and
thus not subject to our backward compatibility rules. (Which, it should be
noted, we applied rather more loosely in python 3.1, 3.2, and even to a smaller
extent in 3.3).
R. David Murray added the comment:
Demien, your patch looks good to me except that it would be better to
consolidate the three adjacent versionchanged entries into one.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
R. David Murray added the comment:
Oh, and the additional what's new text would in this case be pretty much the
contents of that multi-line versionchanged entry, as a bullet item in the
'porting' section. That is, they are behavior changes that are closer to API
fixes than new features, and
Serhiy Storchaka added the comment:
In 2.7 Morsel.set is declared as:
def set(self, key, val, coded_val,
LegalChars=_LegalChars,
idmap=_idmap, translate=string.translate):
Undocumented parameters idmap and translate were removed without deprecation.
idmap was
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Python-bugs-list
Demian Brecht added the comment:
idmap was removed in 14b65de9b798, translate was removed in 99027c2b3fd2 when
their became unnecessary.
I'd venture to say they slipped through the cracks. Following the deprecation
procedure here would be favourable IMHO as to give users a sufficient heads
Demian Brecht added the comment:
The attached patch reverts back to the old set() API, ignoring the parameter
and adding a deprecation warning. I've also added a few versionchanged and
deprecated tags in the Morsel docs. Other than the deprecation note in
whatsnew/3.5.rst that was added, I'm
R. David Murray added the comment:
The change to the signature of set is backward incompatible and should have a
deprecation warning instead (yes, I know it isn't documented). I'd even be OK
with the value being ignored, but the signature shouldn't change.
There are a number of API/behavior
STINNER Victor added the comment:
New changeset 88e1151e8e02 by Serhiy Storchaka in branch 'default':
Issue #2211: Updated the implementation of the http.cookies.Morsel class.
https://hg.python.org/cpython/rev/88e1151e8e02
I don't understand why, but test_pickle started to fail with this
Roundup Robot added the comment:
New changeset 88e1151e8e02 by Serhiy Storchaka in branch 'default':
Issue #2211: Updated the implementation of the http.cookies.Morsel class.
https://hg.python.org/cpython/rev/88e1151e8e02
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
Renamed __copy__ to copy, because copy.copy() doesn't need these changes and
original report was about the copy() method.
Thank you for your contribution and for your responsiveness Demian.
--
resolution: - fixed
stage: commit review - resolved
Serhiy Storchaka added the comment:
Thanks Victor.
This patch should fix pickling/unpickling.
Interesting, we should check all other cases when instance attribute was
converted to a property. They are potentially break pickle compatibility.
--
Added file:
Demian Brecht added the comment:
Thanks for the follow up Serhiy, LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Roundup Robot added the comment:
New changeset d68cc584bc7d by Serhiy Storchaka in branch 'default':
Restored backward compatibility of pickling http.cookies.Morsel. It was
https://hg.python.org/cpython/rev/d68cc584bc7d
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Demian Brecht added the comment:
Thanks for the updates Serhiy. All look good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Changes by Demian Brecht demianbre...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Serhiy Storchaka added the comment:
Here is a patch with extended and unified tests. Also fixed one bug. I have
left comments about some changes on Rietveld.
--
Added file: http://bugs.python.org/file38524/issue2211_6.patch
___
Python tracker
Changes by Demian Brecht demianbre...@gmail.com:
Added file: http://bugs.python.org/file38509/issue2211_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Changes by Demian Brecht demianbre...@gmail.com:
Added file: http://bugs.python.org/file38476/issue2211_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Changes by Demian Brecht demianbre...@gmail.com:
Added file: http://bugs.python.org/file38466/issue2211_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Berker Peksag added the comment:
Serhiy already reviewed the latest patch. Just one more comment: The deprecated
API should be documented in Doc/whatsnew/3.5.rst and
Doc/library/http.cookies.rst.
--
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
Latest patch should address all comments.
--
Added file: http://bugs.python.org/file38432/issue2211_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Demian Brecht added the comment:
New patch addresses most review comments. Thanks for the review Serhiy.
--
Added file: http://bugs.python.org/file38410/issue2211_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
status: languishing - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Serhiy Storchaka added the comment:
Added comments on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Python-bugs-list
Demian Brecht added the comment:
The attached patch should cover the implementation/test aspects of this issue.
I'll work on the documentation next.
--
keywords: +patch
versions: +Python 3.5 -Python 3.2
Added file: http://bugs.python.org/file38170/issue2211.patch
Demian Brecht added the comment:
Never mind, Morsel /is/ documented (at least in Docs). I imagine that the OP
was after more detailed docstrings, but I don't believe they'd add much value.
The patch should be good to go as-is.
--
___
Python tracker
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Demian Brecht added the comment:
@Mark: Sure, but not super high priority. Thanks for pointing it out.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Mark Lawrence added the comment:
@Demian is this of any interest to you?
--
nosy: +BreamoreBoy, demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +merwok
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
___
Python-bugs-list mailing
R. David Murray rdmur...@bitdance.com added the comment:
This looks like it would be a worthwhile cleanup, and the issue contains useful
info to that end, so I'm marking it languishing rather than closing it, in the
hopes that someone will pick it up some day. I also think this could be a
Changes by Toshio Kuratomi [EMAIL PROTECTED]:
--
nosy: +a.badger
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
___
___
Python-bugs-list mailing
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I'm going to push this to pending until you can get a patch. Thanks, Jamie.
--
nosy: +jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
status: open - pending
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
__
___
Python-bugs-list mailing list
Jamie Bliss added the comment:
Sure, I'll do that.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
__
___
Python-bugs-list mailing list
Unsubscribe:
Jamie Bliss added the comment:
* Should be backwards compatible with people who actually use Morsel
* Didn't even attempt to document it
* Instead of having the Morsel dict being filled initially, unset
attributes are, well, unset
* .key, .value, and .coded_value are now property()s
* .value is
Martin v. Löwis added the comment:
Would you be interested to work on a patch?
--
nosy: +loewis
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
__
___
56 matches
Mail list logo
