[issue22110] enable extra compilation warnings

Ned Deily added the comment: See Issue #24324 which modifies configure to not use -Wunreachable-code with gcc for the reasons stated there and by Arfrever above. -- nosy: +ned.deily ___ Python tracker

[issue22110] enable extra compilation warnings

Arfrever Frehtes Taifersar Arahesis added the comment: GCC =4.5.0 (released on 2010-04-14) silently accepts and ignores -Wunreachable-code option. I think that build system of Python should not pass unused options to compiler. -- nosy: +Arfrever

[issue22110] enable extra compilation warnings

Roundup Robot added the comment: New changeset 2c70897e5f98 by Charles-François Natali in branch 'default': Issue #22110: Enable extra compilation warnings. http://hg.python.org/cpython/rev/2c70897e5f98 -- nosy: +python-dev ___ Python tracker

[issue22110] enable extra compilation warnings

Charles-François Natali added the comment: Committed. Sorry for the extra ~70 warnings :-) -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22110

[issue22110] enable extra compilation warnings

Charles-François Natali added the comment: Antoine Pitrou added the comment: Enabling the warnings may be a good incitation for other people to fix them ;) That was my intention... Can I push it, and let warnings be fixed on a case-by-case basis? --

[issue22110] enable extra compilation warnings

Antoine Pitrou added the comment: Le 31/07/2014 13:51, Charles-François Natali a écrit : Enabling the warnings may be a good incitation for other people to fix them ;) That was my intention... Can I push it, and let warnings be fixed on a case-by-case basis? +1 from me. --

[issue22110] enable extra compilation warnings

New submission from Charles-François Natali: The patch attached enables -Wsign-compare and -Wunreachable-code if supported by the compiler. AFAICT, mixed sign comparison warning is automatically enabled by Microsoft's compiler, and is usually a good thing. It does add some warnings though. As

[issue22110] enable extra compilation warnings

Antoine Pitrou added the comment: +1 from me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22110 ___ ___ Python-bugs-list mailing list

[issue22110] enable extra compilation warnings

STINNER Victor added the comment: The patch adds a a lot of new warnings. Would it be possible to fix them before applying the patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22110

[issue22110] enable extra compilation warnings

Antoine Pitrou added the comment: Enabling the warnings may be a good incitation for other people to fix them ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22110 ___

[issue22110] enable extra compilation warnings

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22110 ___ ___