STINNER Victor added the comment:
It would be better to only modify clinic for unsigned types, but how do you
check if a type is signed or not?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22120
Serhiy Storchaka added the comment:
Either override render() for unsigned type converters, or add new converter
attribute (in additional to type, cast, conversion_fn, etc).
--
___
Python tracker rep...@bugs.python.org
Charles-François Natali added the comment:
This patch should probably be moved to its own issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22120
___
Changes by Charles-François Natali cf.nat...@gmail.com:
--
Removed message: http://bugs.python.org/msg224550
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22120
___
STINNER Victor added the comment:
Hum, I forgot the attach the most important patch: fix_warnings.patch.
--
Added file: http://bugs.python.org/file36205/fix_warnings.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22120
New submission from STINNER Victor:
The issue #22110 enabled more compiler warnings. Attached patch tries to fix
most of them on Linux.
--
messages: 224528
nosy: haypo
priority: normal
severity: normal
status: open
title: Fix compiler warnings
___
STINNER Victor added the comment:
clinic.patch: modify clinic.py to generate return_value == (type)-1 instead
of return_value == -1 to avoid a warning if return_value is unsigned.
--
keywords: +patch
nosy: +larry, neologix
Added file: http://bugs.python.org/file36201/clinic.patch
Serhiy Storchaka added the comment:
I think this should be done only for unsigned integer types. Otherwise it just
dirty sources and can hide actual bugs.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
