[issue22133] IDLE: Set correct WM_CLASS on X11

Change by Terry J. Reedy : -- versions: +Python 3.10 -Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22133] IDLE: Set correct WM_CLASS on X11

Changes by Terry J. Reedy : -- assignee: -> terry.reedy stage: -> test needed type: -> behavior versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: Just a suggestion, can we use sys.version_info to get Python major version to have uniform code? Uniform code is too verbose. WM_CLASS should be Idle on Python 2 and Idle3 on Python 3. top = Toplevel(self.root, class_='Idle' if sys.version_info[0] =

[issue22133] IDLE: Set correct WM_CLASS on X11

Saimadhav Heblikar added the comment: I don't know how dialogs and calltip popups behave on Gnome Shell Can you reply what behaviour you want to confirm? If you meant, grouping - Toplevels like ClassBrowser, PathBrowser etc are always grouped as single unit in the Activity Bar. But, in the

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: Here is a patch which sets WM_CLASS of all long-lived toplevel windows. -- Added file: http://bugs.python.org/file36702/idle_wm_class.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22133

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: Grepping idlelib for 'toplevel, there are about 10. Do all of the Toplevels get put on the activity bar? I would not expect that popups like calltip would. I don't know how dialogs and calltip popups behave on Gnome Shell. But I think we should do this

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: And for turtledemo and other gui demos too. No, this is not needed because they are not installed as separate applications and have not specific .desctop file. As said on https://wiki.gnome.org/Projects/GnomeShell/ApplicationBased: To ensure the GNOME 3

[issue22133] IDLE: Set correct WM_CLASS on X11

Saimadhav Heblikar added the comment: Is class_='IDLE' works when only IDLE for Python 3 (not for Python 2) is installed? Shouldn't it be 'IDLE3'? I tried class_=IDLE(or any other string) for python2 repo build, and it works. Most applications on Gnome set it to just the name of the

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: I think we should use class_=IDLE3 (or class_=Idle3) on Python 3. I did not check, but I suppose this should has following effects on Gnome Shell: * Gnome Shell should display IDLE icon from desktop file in different places. * When IDLE is launched, clicking

[issue22133] IDLE: Set correct WM_CLASS on X11

Saimadhav Heblikar added the comment: Saimadhav, please try class_=Idle (title case). I suppose that IDLE's activity bar entry will be named IDLE (upper case), because Gnome Shell will get the name from IDLE's desktop file (/usr/share/applications/idle.desktop). No. It stays Idle. Also there

[issue22133] IDLE: Set correct WM_CLASS on X11

Terry J. Reedy added the comment: We should change window class also for other toplevel windows (from stack viewer to calltip). Grepping idlelib for 'toplevel, there are about 10. Do all of the Toplevels get put on the activity bar? I would not expect that popups like calltip would. I

[issue22133] IDLE: Set correct WM_CLASS on X11

New submission from Saimadhav Heblikar: I found this bug on gnome where IDLE's activity bar entry is named Toplevel instead of IDLE. After digging through the X11 and gnome docs, the WM_CLASS was wrongly being set as Toplevel. This patch has been verified using xprop, that the correct

[issue22133] IDLE: Set correct WM_CLASS on X11

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: Added file: http://bugs.python.org/file36252/after-before.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22133 ___

[issue22133] IDLE: Set correct WM_CLASS on X11

Terry J. Reedy added the comment: Serhiy, do you know if the trivial addition of class_='IDLE' can have any ill effect on non-gnome systems? It looks sensible to me, and I see no effect on Windows. -self.top = top = WindowList.ListedToplevel(root, menu=self.menubar) +self.top = top =

[issue22133] IDLE: Set correct WM_CLASS on X11

Serhiy Storchaka added the comment: I see no effect on KDE. We should change window class also for other toplevel windows (from stack viewer to calltip). And for turtledemo and other gui demos too. -- ___ Python tracker rep...@bugs.python.org