Maciej Szulik added the comment:
Per the discussion we've had with David on IRC here's what happening. The last
patch I've submitted is meant to clean up the tests by:
1. having single _setup method
2. the _setup method should addClenup to clean the environment
3. have stubs with implemented
R. David Murray added the comment:
I'm afraid I don't remember the details of our conversations at PyCon.
Specifically, I don't remember what problem(s) it is you are trying to solve
with this patch.
What is the reason for not just adding your new tests to the
ThreadedNetworkTests test
Maciej Szulik added the comment:
Resubmitting from http://bugs.python.org/issue25591, which I filled in
unnecessarily.
Here are the rewritten test case I've developed during PyCon sprints along with
David. Once we'll have the entire test suite in place it'll be safer to
introduce any
Maciej Szulik added the comment:
Thanks Milan for the info, I was about to ping you about that. I have a working
prototype for the tests that I've been working on during PyCon sprints with
David. I'll try to submit new patch within a couple of next days.
--
Milan Oberkirch added the comment:
Thanks a lot for reviewing my patch! I'm currently travalling so I'm totally
fine with you taking over this issue (would take me a few weeks till I can
work on it).
--
___
Python tracker rep...@bugs.python.org
Maciej Szulik added the comment:
Milan one more thing to change in your patch, in all your TCs you're modifying
client state, I mean this part:
# lets cheat a bit here:
client.state = 'SELECTED'
It's OK to do that on the mocked server, but this is not acceptable doing on
the tested library.
Maciej Szulik added the comment:
Milan, thanks for your patch, I've added comments to it (look for review link
next to submitted file), can you address them please?
Other option is, if you don't mind, I'll take over this issue and finish on top
of your work.
--
nosy: +maciej.szulik
Maciej Szulik added the comment:
One more thing I didn't mention before is, please update it to match current
default, as it's failing patching, right now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
Antoine Pitrou added the comment:
Perhaps you need to close the client connection explicitly? (i.e. shutdown())
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
Milan Oberkirch added the comment:
Okay that was stupid from me (it was 5am when I submitted it), sorry.
--
Added file: http://bugs.python.org/file36271/imaplib_test_rfc3501v2.patch
___
Python tracker rep...@bugs.python.org
New submission from Milan Oberkirch:
I finished writing tests for all methods which are specified in RFC 3501 but
left out extensions for now. The attached patch will trigger many resource
warnings. Do you have an idea why the sockets aren't closed?
--
files:
11 matches
Mail list logo
