[issue22187] commands.mkarg() buggy in East Asian locales

2020-12-01 Thread Irit Katriel
Irit Katriel added the comment: Python 2 only issue. -- nosy: +iritkatriel resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue22187] commands.mkarg() buggy in East Asian locales

2016-09-24 Thread Christian Heimes
Changes by Christian Heimes : -- priority: normal -> low stage: -> needs patch type: security -> behavior ___ Python tracker ___

[issue22187] commands.mkarg() buggy in East Asian locales

2014-10-06 Thread Jakub Wilk
Jakub Wilk added the comment: Something like this should be safe: def mkarg(x): ' ' + pipes.quote(x) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22187 ___

[issue22187] commands.mkarg() buggy in East Asian locales

2014-10-06 Thread Jakub Wilk
Jakub Wilk added the comment: Err, with return of course. :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22187 ___ ___ Python-bugs-list

[issue22187] commands.mkarg() buggy in East Asian locales

2014-10-01 Thread Glyph Lefkowitz
Glyph Lefkowitz added the comment: Would simply replacing this function with pipes.quote resolve the issue? -- nosy: +glyph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22187 ___

[issue22187] commands.mkarg() buggy in East Asian locales

2014-09-05 Thread mirabilos
mirabilos added the comment: Just for the record, please do not assume all shells behave like GNU bash. -- nosy: +mirabilos ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22187 ___

[issue22187] commands.mkarg() buggy in East Asian locales

2014-09-05 Thread R. David Murray
R. David Murray added the comment: That is true, but sh-alikes (posix standard) are the only ones we support in commands. subprocess (which commands was folded in to in python3) also supports windows cmd to the extent we've managed, but that's all we are committed to support. --

[issue22187] commands.mkarg() buggy in East Asian locales

2014-09-05 Thread Jakub Wilk
Jakub Wilk added the comment: I think what mirabilos meant (and what I should have mentioned in my initial message) is that even sh-alikes don't necessarily behave the same way as bash: $ bash test.sh 乗 $ ksh test.sh 乗 $ dash test.sh test.sh: 2: test.sh: Syntax error: Unterminated quoted

[issue22187] commands.mkarg() buggy in East Asian locales

2014-08-12 Thread Jakub Wilk
New submission from Jakub Wilk: This is how shell quoting in commands.mkarg() is implemented: def mkarg(x): if '\'' not in x: return ' \'' + x + '\'' s = ' ' for c in x: if c in '\\$`': s = s + '\\' s = s + c s = s + '' return s This is

[issue22187] commands.mkarg() buggy in East Asian locales

2014-08-12 Thread R. David Murray
R. David Murray added the comment: For the record, neither this module nor this routine exist in python3, so this is a python2 only issue. I'm not sure I fully understand the problem, but perhaps a possible strategy is to apply the fixes to python2's pipes.quote that were applied in python3