Serhiy Storchaka added the comment:
Simplified a code in getargs.c as suggested by Victor.
--
Added file:
http://bugs.python.org/file36556/valueerror_embedded_nul_character_3.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file:
http://bugs.python.org/file36556/valueerror_embedded_nul_character_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file:
http://bugs.python.org/file36557/valueerror_embedded_nul_character_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
STINNER Victor added the comment:
The latest patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
___
Roundup Robot added the comment:
New changeset 25032ec29315 by Serhiy Storchaka in branch 'default':
Issue #22215: Now ValueError is raised instead of TypeError when str or bytes
http://hg.python.org/cpython/rev/25032ec29315
--
___
Python tracker
Serhiy Storchaka added the comment:
Thank you for your review Victor.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
Serhiy Storchaka added the comment:
If there are no objections I'll commit the patch soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
STINNER Victor added the comment:
If there are no objections I'll commit the patch soon.
Replacing TypeError with ValueError is fine. TypeError was a bad choice. If an
application relies on TypeError to check for null character, it's easy to
replace except TypeError: with except (TypeError,
STINNER Victor added the comment:
You may also take a look at these 2 issues: #13617 and #21147 (not directly
related to this oe).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
Serhiy Storchaka added the comment:
Thank you Victor. Here is a patch which is synchronized with the tip and
addresses your comment about a null character.
--
Added file:
http://bugs.python.org/file36546/valueerror_embedded_nul_character_2.patch
Roundup Robot added the comment:
New changeset a058760cb069 by R David Murray in branch '3.4':
#22215: have the smtplib 'quit' command reset the state.
http://hg.python.org/cpython/rev/a058760cb069
New changeset d0d4ab0ba70e by R David Murray in branch 'default':
Merge #22215: have the smtplib
Changes by R. David Murray rdmur...@bitdance.com:
--
Removed message: http://bugs.python.org/msg226149
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
Serhiy Storchaka added the comment:
BDFL have approved the idea
(http://permalink.gmane.org/gmane.comp.python.devel/149000). Could anyone
please make the review of concrete patch?
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22215
___
___
New submission from Serhiy Storchaka:
Currently most functions which accepts string only without embedded NUL
character, raise TypeError. Proposed patch change exception type to more
consistent ValueError. It also unifies error messages.
I have opened a discussion on Python-Dev.
--
16 matches
Mail list logo