[issue22267] fix reliance on refcounting in test_weakref

2014-08-24 Thread Brian Kearns
New submission from Brian Kearns: The test fails on Python implementations with non-refcounted GCs without these lines. Should go on py3k branches also. -- files: test_weakref.patch keywords: patch messages: 225839 nosy: bdkearns priority: normal severity: normal status: open title:

[issue22267] fix reliance on refcounting in test_weakref

2014-08-24 Thread Alex Gaynor
Alex Gaynor added the comment: Perhaps these should use the gc_collect function in test_support? -- nosy: +alex ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22267 ___

[issue22267] fix reliance on refcounting in test_weakref

2014-08-24 Thread Brian Kearns
Brian Kearns added the comment: Possibly. But if so then one would argue there are plenty of other instances where gc_collect should be used, both within test_weakref and the rest of the test suite. Chose gc.collect here as it was used all over test_weakref.py, gc_collect never being used,

[issue22267] fix reliance on refcounting in test_weakref

2014-08-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset b63b8c5628da by Benjamin Peterson in branch '2.7': fix some test_weakref tests to not rely on ref-counting (closes #22267) http://hg.python.org/cpython/rev/b63b8c5628da New changeset b1c82ef96862 by Benjamin Peterson in branch '3.4': fix some