Ned Deily added the comment:
Here's an updated patch for 3.4 and default. To test it, I had to inject a
faulty test server with a timeout error, as the test with the dead URL skips
properly on my system. For 2.7, the test doesn't fail for me even with the
injected server so I propose not
STINNER Victor added the comment:
The patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22289
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 9eb1ce7d8039 by Ned Deily in branch '3.4':
Issue #22289: Prevent test_urllib2net failures due to ftp connection timeout.
https://hg.python.org/cpython/rev/9eb1ce7d8039
New changeset 1aad901e0307 by Ned Deily in branch 'default':
Issue #22289: merge
Ned Deily added the comment:
Thanks for the review. Fix committed for release in 3.4.4 and 3.5.0.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
Ned Deily added the comment:
There seems to be a small problem with the patch that can be easily fixed by
changing the test for ftp error: timeout() to ftp error: timeout(.
Otherwise, it seems OK. Note that there is now also a related patch for
Issue22596 that modifies the same test.
New submission from STINNER Victor:
Attached patch should fix the following sporadic error. I wrote the patch for
Python 3.5. I will adapt it for Python 2.7 and 3.4 if the review is positive.
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/4837/steps/test/logs/stdio
