[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: Thanks for your help with this Xavier. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22359] Remove incorrect uses of recursive make

Roundup Robot added the comment: New changeset 66e40df31fac by Martin Panter in branch '3.5': Issue #22359: Disable running cross-compiled _freeze_importlib and pgen https://hg.python.org/cpython/rev/66e40df31fac New changeset c36b9ef8ff39 by Martin Panter in branch 'default': Issue #22359:

[issue22359] Remove incorrect uses of recursive make

Xavier de Gaye added the comment: _freeze_importlib and pgen are cross-built in this patch. Patch tested with a run of the testsuite after a cross-build. -- Added file: http://bugs.python.org/file42554/crossbuild-sources-readonly_2.patch ___ Python

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: For the record, to fix this in 2.7 will involve backporting revision c2a53aa27cad, plus Xavier’s patch (except the freeze_importlib parts which is not relevant to 2.7). -- ___ Python tracker

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: I see. I guess it would keep the makefile simpler if we cross-compiled both programs, and never used them. -- ___ Python tracker

[issue22359] Remove incorrect uses of recursive make

Xavier de Gaye added the comment: > Why do you make the linking of _freeze_importlib conditional, but always > build $(PGEN)? Yes, this is not consistent. The cross-build is correct when both are linked or when both are not linked. And $(PGENOBJS) are cross-compiled in both cases. Should

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: Looks pretty good. One more question: Why do you make the linking of _freeze_importlib conditional, but always build $(PGEN)? -- ___ Python tracker

[issue22359] Remove incorrect uses of recursive make

Xavier de Gaye added the comment: Martin, thanks for the review and the suggestions. The attached patch makes the following changes: * do not modify the source files so as not to break builds made from read-only build sources (as per issue 15819) * the cross-build copies the graminit.[ch]

[issue22359] Remove incorrect uses of recursive make

Changes by Martin Panter : -- dependencies: -When cross-compiling, don’t try to execute binaries status: languishing -> open ___ Python tracker

[issue22359] Remove incorrect uses of recursive make

Xavier de Gaye added the comment: > But I am a bit worried at the new makefile syntax [ifeq directive and > $(findstring) function]. I suspect it is Gnu specific, and that Python tries > to support other versions of Make as well. Yes, they are both GNU extensions :( To avoid modifying

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: Here is a patch implementing my idea to make file reneration a separate step, not automatically run during the normal build process. But it is sounding like other people don’t like this idea, so Xavier’s approach might be less controversial even if it is more

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: Thanks for you work Xavier. Making it conditional on cross compilation is another approach I hadn’t thought of. But I am a bit worried at the new makefile syntax [ifeq directive and $(findstring) function]. I suspect it is Gnu specific, and that Python tries

[issue22359] Remove incorrect uses of recursive make

Xavier de Gaye added the comment: This patch improves changeset c2a53aa27cad by allowing cross-compilation: The following checks have been made: * successfull cross-compilation of python3.4 after retrofiting changeset c2a53aa27cad to python3.4 since I don't have a working

[issue22359] Remove incorrect uses of recursive make

Changes by Martin Panter vadmium...@gmail.com: -- stage: commit review - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___ ___

[issue22359] Remove incorrect uses of recursive make

koobs added the comment: Initial commit to default is done. Backport to 2.7 3.4 branches remains to do -- components: -Cross-Build keywords: +easy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359

[issue22359] Remove incorrect uses of recursive make

koobs added the comment: Add 3.5 to list of versions merging required for -- versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___

[issue22359] Remove incorrect uses of recursive make

koobs added the comment: martin: yes, if the incorrect usage of recursive make is in the 2.7 and 3.4 branches and the fix is relevant to the issues I reported. Of course all subsequent changes (fixing cross-builds) should be applied there too. --

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: My math and cmath issue seems to be completely separate. I opened Issue 24421 for that, so sorry for the noise here :) I think the patch here should be applied (or adapted if necessary) to the 3.4 and 2.7 branches. If it breaks cross compilation, then the

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: koobs: It sounds like applying the fix for this bug to the Python 2 branch might satisfy you, right? It only seems to have been applied to 3.5+ so far. Matt: It sounds like you are trying to pre-compile $(PGEN) for the host, and then rely on it not being

[issue22359] Remove incorrect uses of recursive make

Changes by koobs koobs.free...@gmail.com: -- nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___ ___ Python-bugs-list mailing

[issue22359] Remove incorrect uses of recursive make

koobs added the comment: We've (FreeBSD) seen and received several random and intermittent reports of failures during this stage of the build for all versions of Python, resulting in errors such as, among others: Parser/pgen.o: file not recognized: File truncated *** [Parser/pgen] Error code

[issue22359] Remove incorrect uses of recursive make

Martin Panter added the comment: FWIW two times recently I saw strange intermittent build errors. I use “make -j2” on Linux. The one time that I investigated was a Python module (math or cmath perhaps?) failing to build because some dependency was zero bytes, and looking through the build

[issue22359] Remove incorrect uses of recursive make

Changes by koobs koobs.free...@gmail.com: -- stage: resolved - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___ ___

[issue22359] Remove incorrect uses of recursive make

Matthias Klose added the comment: reopening, breaks cross builds. I'll have a look -- resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___

[issue22359] Remove incorrect uses of recursive make

Matt Frank added the comment: Sorry, I'm complaining. Cross builds broke. Please see issue22809. -- nosy: +WanderingLogic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___

[issue22359] Remove incorrect uses of recursive make

Roundup Robot added the comment: New changeset c2a53aa27cad by Antoine Pitrou in branch 'default': Issue #22359: Remove incorrect uses of recursive make. Patch by Jonas Wagner. https://hg.python.org/cpython/rev/c2a53aa27cad -- nosy: +python-dev ___

[issue22359] Remove incorrect uses of recursive make

Antoine Pitrou added the comment: Ok, I've pushed the patch. Let's see if anyone complains. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359

[issue22359] Remove incorrect uses of recursive make

Antoine Pitrou added the comment: Martin, Matthias, do you think this would break any legitimate use? -- nosy: +loewis, pitrou stage: - patch review type: compile error - behavior ___ Python tracker rep...@bugs.python.org

[issue22359] Remove incorrect uses of recursive make

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___

[issue22359] Remove incorrect uses of recursive make

New submission from Jonas Wagner: The attached patch fixes issues with Python's Makefile, which manifest when doing parallel builds. The Makefile invoked make recursively for some targets. This caused some files (which were depended upon by multiple targets) to be built by both the original

[issue22359] Remove incorrect uses of recursive make

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +doko ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___ ___ Python-bugs-list

[issue22359] Remove incorrect uses of recursive make

Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22359 ___ ___ Python-bugs-list