Roundup Robot added the comment:
New changeset e4b986350feb by Antoine Pitrou in branch '3.4':
Close issue #22895: fix test failure introduced by the fix for issue #22462.
https://hg.python.org/cpython/rev/e4b986350feb
New changeset 4990157343c6 by Antoine Pitrou in branch 'default':
Close
Changes by Jeremy Kloth jeremy.kloth+python-trac...@gmail.com:
--
nosy: +jkloth
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22462
___
___
Matthias Klose added the comment:
according to https://jenkins.qa.ubuntu.com/job/vivid-adt-python3.4/7/
test.test_pyexpat.HandlerExceptionTest now fails, but only when running in the
installed location, not when running the tests from the builddir. any idea why?
--
nosy: +doko
Roundup Robot added the comment:
New changeset 5433ef907e4f by Antoine Pitrou in branch '3.4':
Issue #22462: Fix pyexpat's creation of a dummy frame to make it appear in
exception tracebacks.
https://hg.python.org/cpython/rev/5433ef907e4f
New changeset f2f13aeb590a by Antoine Pitrou in branch
Antoine Pitrou added the comment:
Patch pushed. I've kept the changes together :) Hopefully there won't be any
ctypes regression.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Here is an updated patch with a test.
--
Added file: http://bugs.python.org/file36833/expat_traceback.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22462
Georg Brandl added the comment:
Not sure how this can violate PEP 384, as it doesn't make it mandatory for
builtin extensions to use the stable ABI.
The other concerns seem valid, although I don't like how the patch includes an
unrelated change to ctypes.
--
nosy: +georg.brandl,
Mark Shannon added the comment:
W.r.t PEP 384:
Every module, except pyexpat, in the stdlib library treats frames as opaque
objects, as PEP 384 requires.
(I'm exempting builtins and sys here)
I think it is unreasonable to expect authors of 3rd party modules to respect
PEP 384 if the standard
Changes by Antoine Pitrou pit...@free.fr:
--
stage: - patch review
type: - behavior
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22462
___
Antoine Pitrou added the comment:
FWIW, I think the patch's approach is ok. I just did a small comment on the
review UI.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22462
___
Georg Brandl added the comment:
I think it is unreasonable to expect authors of 3rd party modules to respect
PEP 384 if the standard library does not.
I don't understand why you think that. PEP 384 is intended to provide the
means to maintain binary compatibility of extension modules so
New submission from Mark Shannon:
Modules/pyexpat.c includes some archaic code to create temporary frames
so that, in even of an exception being raised, expat appears in the traceback.
The way this is implemented is a problem for three reasons:
1. It violates PEP 384.
2. It is incorrect, see
Changes by Mark Shannon m...@hotpy.org:
--
nosy: +nedbat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22462
___
___
Python-bugs-list mailing list
13 matches
Mail list logo
