Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
___
Georg Brandl added the comment:
Addressing review comments.
--
Added file:
http://bugs.python.org/file36789/pyobject_issubclass_isinstance_speedup_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 4f33a4a2b425 by Georg Brandl in branch 'default':
Closes #22540: speed up PyObject_IsInstance and PyObject_IsSubclass in the
common case that the second argument has metaclass type.
https://hg.python.org/cpython/rev/4f33a4a2b425
--
nosy:
STINNER Victor added the comment:
A buildbot is failing since your change.
http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/1261/steps/test/logs/stdio
==
ERROR: test_decimal_fraction_comparison
Antoine Pitrou added the comment:
The test_decimal failure can be reproduced using:
./python -m test -W test_datetime test_decimal
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
Roundup Robot added the comment:
New changeset 6cfe929d1de5 by Antoine Pitrou in branch 'default':
Make test_datetime a better citizen (issue #22540)
https://hg.python.org/cpython/rev/6cfe929d1de5
--
___
Python tracker rep...@bugs.python.org
Georg Brandl added the comment:
Thanks for fixing! I did run make test locally, but that did not produce the
failure.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
___
New submission from Georg Brandl:
With the introduction of ABCs, PyObject_IsInstance (and for this issue,
everything is also valid for PyObject_IsSubclass) has to check for a type's
__instancecheck__ before falling back to the built-in behavior.
However, the type type has an __instancecheck__
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
___
___
Python-bugs-list
10 matches
Mail list logo