Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
Benjamin Peterson added the comment:
Thanks for the very high quality patch. The way it was split made it much
easier to review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
Eldar Abusalimov added the comment:
You're welcome, and thank you too for reviewing and merging it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
Roundup Robot added the comment:
New changeset 6384c0cd3b2d by Benjamin Peterson in branch '3.4':
fix many custom mro() edge cases and improve code quality (#22735)
https://hg.python.org/cpython/rev/6384c0cd3b2d
New changeset 75fd0bd89eef by Benjamin Peterson in branch 'default':
merge 3.4
Eldar Abusalimov added the comment:
I feel a bit uneasy, but... any news on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
___
Benjamin Peterson added the comment:
I will try to look eventually.
--
assignee: - benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
Eldar Abusalimov added the comment:
ping?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
___
Python-bugs-list mailing list
Eldar Abusalimov added the comment:
Thank you for your replies.
I don't think forbidding reentrancy is a good idea, and I'm against it for the
following reasons.
First of all, naive prohibition of type_set_bases within mro() on a class
doesn't save from mro() reentrancy:
def mro(cls):
Antoine Pitrou added the comment:
I think forbidding reentrancy would indeed be a good idea.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
___
Benjamin Peterson added the comment:
Thank you for the patchset. I wonder if we should just forbid most reentrancy
i.e. set a flag on the type when it's being constructed and not let
type_set_bases be called then. Setting __bases__ from within mro() doesn't seem
very useful outside of
New submission from Eldar Abusalimov:
The attached patch fixes several bugs revealed by providing a custom mro().
Most of these bugs are reentrancy issues (mainly, cls.__bases__ assignment
within mro() which causes incorrect refcounting), but there are also some
issues when using incomplete
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37026/0001-minor-test_mro-test-case-stub-and-helpers.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37029/0004-minor-type_set_bases-move-undoing-logic-to-the-end.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37027/0002-test-crashers-NULL-old_mro-and-over-decref-on-reent.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37030/0005-minor-type_set_bases-extract-add_all_subclasses.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37028/0003-minor-mro_internal-extract-mro_invoke-and-mro_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37031/0006-minor-mro_subclasses-loop-over-a-list-of-subclasses.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Eldar Abusalimov added the comment:
This is a patch with most significant changes, please review it carefully.
--
Added file:
http://bugs.python.org/file37032/0007-fix-handle-tp_mro-overwritten-through-reentrancy.patch
___
Python tracker
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37033/0008-test-crashers-tp_base-tp_subclasses-inherit-cycles.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37034/0009-minor-PyType_IsSubtype-extract-a-check-using-tp_base.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37035/0010-fix-type_set_bases-inherit-cycles-and-reent-checks.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37037/0012-minor-mro_implementation-pmerge-refactory.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37038/0013-fix-mro_implementation-check-base-tp_mro-is-not-NULL.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37036/0011-test-behavior-error-on-extending-an-incomplete-type.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37039/0014-test-crasher-attr-lookup-on-super-with-uninitialized.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37040/0015-fix-super_getattro-check-type-tp_mro-and-refactory.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Eldar Abusalimov added the comment:
Just in case, the previous message about reviewing is about [PATCH 07/15] (fix)
handle tp_mro overwritten through reentrancy
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
27 matches
Mail list logo
