Tim Graham added the comment:
Updated patch per comments.
--
Added file:
http://bugs.python.org/file37114/cookie-pickling-all-protocols-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
Serhiy Storchaka added the comment:
LGTM.
--
assignee: - serhiy.storchaka
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
Roundup Robot added the comment:
New changeset 7be6ef737aaf by Serhiy Storchaka in branch '3.4':
Issue #22775: Fixed unpickling of http.cookies.SimpleCookie with protocol 2
https://hg.python.org/cpython/rev/7be6ef737aaf
New changeset caa8f9248ab8 by Serhiy Storchaka in branch 'default':
Issue
Serhiy Storchaka added the comment:
Thank you for your contribution Tim.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
Roundup Robot added the comment:
New changeset 515331e0ca0c by Serhiy Storchaka in branch '2.7':
Issue #22775: Fixed unpickling of Cookie.SimpleCookie with protocol 2.
https://hg.python.org/cpython/rev/515331e0ca0c
--
___
Python tracker
Serhiy Storchaka added the comment:
Test pickling with all protocols (see issue22777), not only with
HIGHEST_PROTOCOL.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
Tim Graham added the comment:
Updated patch to test pickling of all protocols.
--
Added file: http://bugs.python.org/file37100/cookie-pickling-all-protocols.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
New submission from Tim Graham:
Expected:
import pickle
from http.cookies import SimpleCookie
pickle.loads(pickle.dumps(SimpleCookie('hi=there'),2))
SimpleCookie: hi='there'
# Actual
SimpleCookie: hi='Set-Cookie: hi=there'
Patch is based on the suggestion from Georg Brandl in #22758 (I
Tim Graham added the comment:
By the way, this is my first patch for Python and I submitted a CLA 2 days ago.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: - patch review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22775
___
___
Python-bugs-list
12 matches
Mail list logo