[issue22847] Improve method cache efficiency

Roundup Robot added the comment: New changeset 04424651f76c by Benjamin Peterson in branch '2.7': fix hash member name (closes #22847) https://hg.python.org/cpython/rev/04424651f76c -- resolution: -> fixed status: open -> closed ___ Python tracker <

[issue22847] Improve method cache efficiency

Changes by koobs : -- resolution: fixed -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue22847] Improve method cache efficiency

koobs added the comment: It appears this change broke all FreeBSD builders (9: gcc, 10/11: clang) for the 2.7 branch with: koobs-freebsd-current (clang 3.7.x) cc -pthread -c -fno-strict-aliasing -OPT:Olimit=0 -g -O2 -g -O0 -Wall -Wstrict-prototypes -I. -IInclude -I./Include -DPy_BUILD_

[issue22847] Improve method cache efficiency

Benjamin Peterson added the comment: I suppose we've backported scarier things. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue22847] Improve method cache efficiency

Roundup Robot added the comment: New changeset 6357d851029d by Antoine Pitrou in branch '2.7': Issue #22847: Improve method cache efficiency. https://hg.python.org/cpython/rev/6357d851029d -- ___ Python tracker ___

[issue22847] Improve method cache efficiency

Gregory P. Smith added the comment: I'm reopening this and assigning it to benjamin as the 2.7 release manager. This change is valuable to apply to 2.7.x as well. It is very simple and is a clear performance improvement for realistic workloads. No API change. When you profile Python 2.7 app

[issue22847] Improve method cache efficiency

Antoine Pitrou added the comment: Now pushed. Thanks for the comments! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue22847] Improve method cache efficiency

Roundup Robot added the comment: New changeset 97dc64adb6fe by Antoine Pitrou in branch 'default': Issue #22847: Improve method cache efficiency. https://hg.python.org/cpython/rev/97dc64adb6fe -- nosy: +python-dev ___ Python tracker

[issue22847] Improve method cache efficiency

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22847] Improve method cache efficiency

Raymond Hettinger added the comment: Thanks for adding the instrumentation. Otherwise, it would have been difficult to tell whether the xor hashing had a significant deleterious effect on collisions. Also, +1 on bumping up the cache size. -- nosy: +rhettinger ___

[issue22847] Improve method cache efficiency

Antoine Pitrou added the comment: In addition, the tp_version_tag evolves incrementally, so the low bits should be better when the same name is looked up on different types. -- ___ Python tracker _

[issue22847] Improve method cache efficiency

Antoine Pitrou added the comment: The low bits of the unicode hash should be as good as the middle bits. -- ___ Python tracker ___ ___

[issue22847] Improve method cache efficiency

Serhiy Storchaka added the comment: FYI method cache optimization was added in issue1700288. -- nosy: +arigo ___ Python tracker ___ __

[issue22847] Improve method cache efficiency

Serhiy Storchaka added the comment: Current hashing algorithm takes middle bits, proposed code takes low bits. Doesn't this make the hash worse? -- ___ Python tracker ___ __

[issue22847] Improve method cache efficiency

Antoine Pitrou added the comment: It's not easy to get stable benchmark runs, but here is an example: Report on Linux fsol 3.16.0-24-generic #32-Ubuntu SMP Tue Oct 28 13:07:32 UTC 2014 x86_64 x86_64 Total CPU cores: 4 ### 2to3 ### 7.083762 -> 6.904087: 1.03x faster ### formatted_logging ### M

[issue22847] Improve method cache efficiency

New submission from Antoine Pitrou: The method cache is currently very small. Attached patch bumps the size a bit and improves the hash computation formula. -- components: Interpreter Core files: methcache.patch keywords: patch messages: 231031 nosy: pitrou, serhiy.storchaka priority: n