[issue22865] Document how to make pty.spawn not copy data

STINNER Victor added the comment: Thanks Geoff Shannon for the doc enhancement! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22865] Document how to make pty.spawn not copy data

STINNER Victor added the comment: New changeset cdb2dbfe92b95dcd19ccab1a1e9b8c39263c54b0 by Victor Stinner (Geoff Shannon) in branch '3.7': [3.7] bpo-22865: Expand on documentation for the pty.spawn function (GH-11980) (GH-13455)

[issue22865] Document how to make pty.spawn not copy data

Change by Geoff Shannon : -- pull_requests: +13364 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22865] Document how to make pty.spawn not copy data

STINNER Victor added the comment: New changeset 522ccef8690970fc4f78f51a3adb995f2547871a by Victor Stinner (Geoff Shannon) in branch 'master': bpo-22865: Expand on documentation for the pty.spawn function (GH-11980)

[issue22865] Document how to make pty.spawn not copy data

Geoff Shannon added the comment: @martin.panter I removed the mention of inserting null bytes and restricted the documentation updates to more fully documenting the current behaviour. -- ___ Python tracker

[issue22865] Document how to make pty.spawn not copy data

Martin Panter added the comment: I'm not sure it is wise for the Python documentation to suggest inserting null bytes in general. This seems more like an application-specific hack. There is nothing in Python that handles these null bytes specially, and I expect they will be seen if the

[issue22865] Document how to make pty.spawn not copy data

Cheryl Sabella added the comment: Thanks @RadicalZephyr! @martin.panter, please review the PR when you get a chance. Thank you! -- ___ Python tracker ___

[issue22865] Document how to make pty.spawn not copy data

Geoff Shannon added the comment: It is submitted @cheryl.sabella. Thanks for reviving this, I had totally lost track of it. -- ___ Python tracker ___

[issue22865] Document how to make pty.spawn not copy data

Change by Roundup Robot : -- pull_requests: +12004 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22865] Document how to make pty.spawn not copy data

Cheryl Sabella added the comment: @RadicalZephyr, are you interested in making a GitHub pull request with the recommended the documentation change? -- nosy: +cheryl.sabella versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5, Python 3.6

[issue22865] Document how to make pty.spawn not copy data

Martin Panter added the comment: I would avoid suggesting one can return non-byte-strings; treat that as an implementation detail. Maybe something like: The functions *master_read* and *stdin_read* are passed a file descriptor which they should read from, and should return a byte string. The

[issue22865] Document how to make pty.spawn not copy data

Martin Panter added the comment: If you return null bytes, they will be written to the parent process’s stdout file descriptor, rather than being ignored. I do not think it is possible to ignore output with the spawn() API, unless perhaps you previously set up stdout write to /dev/null or

[issue22865] Document how to make pty.spawn not copy data

Geoff Shannon added the comment: Hmm, I spoke improperly. I think you are entirely correct in your statements. What I meant by "terminals ignore null bytes" is that returning a string consisting of only a null byte doesn't cause anything observable to happen, including anything to be

[issue22865] Document how to make pty.spawn not copy data

Geoff Shannon added the comment: Hey, pinging this issue. Hoping someone has time to take a look at it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22865 ___

[issue22865] Document how to make pty.spawn not copy data

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +twouters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22865 ___ ___ Python-bugs-list

[issue22865] Document how to make pty.spawn not copy data

Geoff Shannon added the comment: Okay, I just found another way to achieve the same effect of letting the _read function ignore data but not inadvertantly close the stream. It relies on the fact that terminals will ignore null bytes fed to them. Now there are no code changes required, just