[issue22891] code removal from urllib.parse.urlsplit()

Gregory P. Smith added the comment: There are still a lot of cleanliness and even logical issues lurking within urllib.parse. But this bug is dated and other changes have happened since. I'm closing it as out of date. Open new issues for specific action items. -- nosy:

[issue22891] code removal from urllib.parse.urlsplit()

Senthil Kumaran added the comment: New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in branch '3.8': [3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839) https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 --

[issue22891] code removal from urllib.parse.urlsplit()

Change by Senthil Kumaran : -- pull_requests: +16391 pull_request: https://github.com/python/cpython/pull/16839 ___ Python tracker ___

[issue22891] code removal from urllib.parse.urlsplit()

miss-islington added the comment: New changeset 82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f by Miss Islington (bot) in branch '3.7': bpo-27657: Fix urlparse() with numeric paths (GH-661) https://github.com/python/cpython/commit/82b5f6b16e051f8a2ac6e87ba86b082fa1c4a77f -- nosy:

[issue22891] code removal from urllib.parse.urlsplit()

Change by miss-islington : -- pull_requests: +16385 pull_request: https://github.com/python/cpython/pull/16837 ___ Python tracker ___

[issue22891] code removal from urllib.parse.urlsplit()

Senthil Kumaran added the comment: New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim Graham) in branch 'master': bpo-27657: Fix urlparse() with numeric paths (#661) https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c87644a9034c969 --

[issue22891] code removal from urllib.parse.urlsplit()

Tim Graham added the comment: I sent a pull request for this issue's dependency (issue 27657) and added a second commit there with this patch. A test added in the first commit demonstrates that removing this code no longer results in the behavior change described in msg238254. --

[issue22891] code removal from urllib.parse.urlsplit()

Martin Panter added the comment: Issue 27657 has been opened about the quirk with numeric URLs -- dependencies: +urlparse fails if the path is numeric ___ Python tracker

[issue22891] code removal from urllib.parse.urlsplit()

Martin Panter added the comment: The patch seems sensible. The only behaviour change I can forsee would be the odd case of http:1234 no longer being parsed like this: urlsplit(http:1234) SplitResult(scheme='http', netloc='', path='1234', query='', fragment='') Instead it would be parsed the

[issue22891] code removal from urllib.parse.urlsplit()

Alexander Todorov added the comment: Does test cases pass after removal of those lines? (I will be surprised) Yes they do. Also see my detailed explanation above, there's no reason for test cases to fail. -- ___ Python tracker

[issue22891] code removal from urllib.parse.urlsplit()

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +orsenthil stage: - patch review title: [patch]: code removal from urllib.parse.urlsplit() - code removal from urllib.parse.urlsplit() versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.6

[issue22891] code removal from urllib.parse.urlsplit()

Senthil Kumaran added the comment: Thanks for filing this. Does test cases pass after removal of those lines? (I will be surprised) and if the tests fail, then after analyzing it, this could only be considered a new change (thus change to made in latest python) in order not to break