[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Hmm, I have no ideas how I missed this when ran tests. Thank you Berker. -- ___ Python tracker ___ ___

[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1ab04bcd03bf by Serhiy Storchaka in branch '3.4': Issue #23071: "namereplace_errors" was added only in 3.5. https://hg.python.org/cpython/rev/1ab04bcd03bf -- ___ Python tracker

[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Berker Peksag
Berker Peksag added the comment: In 3.4, "namereplace_errors" needs to be removed in the test: https://hg.python.org/cpython/rev/2b642f2ca391#l2.17 == FAIL: test_all (test.test_codecs.CodecsModuleTest) -

[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your patch Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset c6491d91d59a by Serhiy Storchaka in branch '2.7': Issue #23071: Added missing names to codecs.__all__. Patch by Martin Panter. https://hg.python.org/cpython/rev/c6491d91d59a New changeset 2b642f2ca391 by Serhiy Storchaka in branch '3.4': Issue #230

[issue23071] codecs.__all__ incomplete

2014-12-20 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23071] codecs.__all__ incomplete

2014-12-18 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: +1 -- nosy: +lemburg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue23071] codecs.__all__ incomplete

2014-12-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23071] codecs.__all__ incomplete

2014-12-17 Thread Martin Panter
Martin Panter added the comment: This patch includes a new test; although this kind of testing won’t detect when someone adds a new API and forgets to add it to __all__. -- Added file: http://bugs.python.org/file37491/codecs-all.patch ___ Python trac

[issue23071] codecs.__all__ incomplete

2014-12-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks! Could you also add a test? See PublicAPITests in Lib/test/test_shutil.py as an example. -- stage: needs patch -> patch review ___ Python tracker ___

[issue23071] codecs.__all__ incomplete

2014-12-17 Thread Martin Panter
Martin Panter added the comment: Here is the patch (against the default branch) -- keywords: +patch Added file: http://bugs.python.org/file37486/codecs-all.patch ___ Python tracker _

[issue23071] codecs.__all__ incomplete

2014-12-16 Thread Martin Panter
Martin Panter added the comment: Okay I will try and make a patch for this once I have finished a patch to revise the documentation for Issue 19548 -- ___ Python tracker ___ ___

[issue23071] codecs.__all__ incomplete

2014-12-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, only documented names should be in __all__. Do you want to provide a patch Martin? Suggestion: first filter names which are contained in codecs.rst. -- keywords: +easy nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 2.7, Python 3

[issue23071] codecs.__all__ incomplete

2014-12-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23071] codecs.__all__ incomplete

2014-12-16 Thread Martin Panter
New submission from Martin Panter: First ones I noticed were codecs.encode() and codecs.decode(). Here is a list of other candidates, although they are not all documented, so maybe should not all be in __all__. >>> import codecs >>> public = (a for a in dir(codecs) if not a.startswith("_")) >>