[issue23262] webbrowser module broken with Firefox 36+

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

wyz23x2 added the comment: I think this six year old issue can be closed. All patches for 3.x are committed, and Python 2.7 is EOL. -- nosy: +wyz23x2 ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Syaifulnizam Shamsudin added the comment: Processo webbrowser.3.5-2.patch -- nosy: +Syaifulnizam ___ Python tracker ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Serhiy Storchaka : -- pull_requests: -903 ___ Python tracker ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Donald Stufft : -- pull_requests: +903 ___ Python tracker ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Serhiy Storchaka : -- assignee: serhiy.storchaka -> ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: > I'm not sure that we can break the compatibility with old browser I agree with this. -- ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: I don't understand with what you disagree. I can imagine old Python 2.7 with old browser, old Python 2.7 with new browser, new Python 2.7 with new browser, and even new Python 2.7 with old browser on the same computer (but the latter is very unlikely). Old

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Let's me disagree because Python 2.7 is a very special case. One can easily update a browser — they are perfectly compatible. But one cannot just update Python 2.7 because Python 3 is rather a different language that requires a lot of porting effort. So I can

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: What to do with 2.7? We can just backport the patch from 3.5, but also can use the version check from earlier Oleg's patches. 2.7 was released long time ago and still can be used on systems with old browsers (however it is very unlikely that Python is

[issue23262] webbrowser module broken with Firefox 36+

Roundup Robot added the comment: New changeset dacb52577c1c by Serhiy Storchaka in branch '3.5': Issue #23262: The webbrowser module now supports Firefox 36+ and derived https://hg.python.org/cpython/rev/dacb52577c1c New changeset f1abc92a756a by Serhiy Storchaka in branch '3.6': - Issue

[issue23262] webbrowser module broken with Firefox 36+

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Then I don't have any objections. But I also couldn't test the change — I only use Firefox (and sometimes Chrome). -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Currently Netscape is just an alias to Mozilla. Since SeaMonkey is synchronized with Firefox, I suppose it dropped the support of the -remote option at the same time. Debian rebranded Firefox and SeaMonkey at 2006, therefore IceWeasel and IceApe always

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I'd rather rename the new class to something like Firefox. So there will be 3 classes — Netscape, Mozilla and Firefox. Firefox only for firefox executable. -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: The problem is that this class is used for Netscape and old Mozilla browsers. What if rename old Mozilla class to Netscape and use it for old browsers? -- Added file: http://bugs.python.org/file45237/webbrowser.py-3.5-2.patch

[issue23262] webbrowser module broken with Firefox 36+

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45236/webbrowser.py-3.5.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Done. -- versions: -Python 2.7 Added file: http://bugs.python.org/file45228/webbrowser.py-3.5.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file45025/webbrowser.py-3.4-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file45216/webbrowser.py-3.5-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file45027/webbrowser.py-2.7-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file45218/test_webbrowser.py-3.5-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Could you please provide a patch including all changes in unified format? -- ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Oops, yes, mea culpa, sorry. Patch for the test added. -- Added file: http://bugs.python.org/file45218/test_webbrowser.py-3.5-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: $ ./python -m test.regrtest -vuall test_webbrowser ... == FAIL: test_open (test.test_webbrowser.MozillaCommandTest) --

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: What's the error? Buildbot URL? -- ___ Python tracker ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Tests are failed with webbrowser.py-3.5-newfox.patch. -- versions: +Python 3.7 ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Ah, I see. Ok then, see the new patch. -- Added file: http://bugs.python.org/file45216/webbrowser.py-3.5-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: > I don't think Firefox versions <36 are too old to be dropped. Just Firefox versions <1.5. Firefox 1.5 released 11 years ago supported options -new-window and -new-tab [1]. [1]

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I don't think Firefox versions <36 are too old to be dropped. -- ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Would not be easier to drop a support of SeaMonkey 1.x and other ancient browsers? -- ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file45024/webbrowser.py-2.7-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Remove empty args (backported from 3.4). -- Added file: http://bugs.python.org/file45027/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Add NewFox class to webbrowser for Py 3.4 (added raise_opts — Mozilla no longer supports autoraise). -- Added file: http://bugs.python.org/file45025/webbrowser.py-3.4-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Add NewFox class to webbrowser for Py 2.7 (added raise_opts — Mozilla no longer supports autoraise). -- Added file: http://bugs.python.org/file45024/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file43752/webbrowser.py-3.4-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file43751/webbrowser.py-2.7-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file43749/webbrowser.py-3.4-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file43748/webbrowser.py-2.7-newfox.patch ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by Oleg Broytman : Removed file: http://bugs.python.org/file38227/new_firefox.py ___ Python tracker ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I am on Debian 8 "jessie" that only has Python 3.4, so I want to patch webbrowser.py in a backward-compatible way. -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Berker Peksag added the comment: I was talking about webbrowser.py-3.4-newfox.patch 3.4 is now in security-fix-only mode so we can't push the patch to the 3.4 branch. -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Updated patch for Python 2.7 with subprocess.check_output(). -- Added file: http://bugs.python.org/file43751/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Updated patch for Python 3.4+ with subprocess.check_output(). -- Added file: http://bugs.python.org/file43752/webbrowser.py-3.4-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Not subprocess.run() as I'm aiming to Python 2.7. Perhaps subprocess.check_output(). I'll try it. -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Berker Peksag added the comment: Thanks for the patches! Can't you just use a function from the high level subprocess API (like subprocess.run()? -- stage: -> patch review versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Patch for Python 3.4 and 3.5 to support Firefox >= 36.0, with version test. -- Added file: http://bugs.python.org/file43749/webbrowser.py-3.4-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Patch for Python 2.7 to support Firefox >= 36.0, with version test. -- keywords: +patch Added file: http://bugs.python.org/file43748/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

[issue23262] webbrowser module broken with Firefox 36+

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Changes by lilydjwg lilyd...@gmail.com: -- nosy: +lilydjwg ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___ ___ Python-bugs-list mailing

[issue23262] webbrowser module broken with Firefox 36+

bazwal added the comment: this will break the support of IceApe on Debian Etch Is Python committed to supporting obsolete Debian releases? The latest oldstable Debian release (6.0 Squeeze) has iceape-2.0.11 [1], which does seem to support the -new-window and -new-tab options (I haven't

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: May it is time to drop support of SeaMonkey 1.x and systems released 8 years ago. But then we should drop the support of browsers netsape, mozilla, firebird. And this should be documented somewhere. -- ___ Python

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: --new-window and --new-tab are Firefox and SeaMonkey2.x only. [1] So this will break the support of IceApe on Debian Etch (iceape v.1.0.13 [2]). [1] https://developer.mozilla.org/en-US/docs/Mozilla/Command_Line_Options [2]

[issue23262] webbrowser module broken with Firefox 36+

bazwal added the comment: I arrived at an almost identical solution to the one given by Oleg. It works for me with FF 28, 35 36 - but presumably there are earlier versions where it does not, otherise why have the -remote option at all? The gist of the Mozilla bug report is that the option

[issue23262] webbrowser module broken with Firefox 36+

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___ ___

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I created the attached module to work with new FF in Python 2.7. You can convert it to proper patch for webbrowser.py. -- nosy: +phd Added file: http://bugs.python.org/file38227/new_firefox.py ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Antoine Pitrou added the comment: What is the right way to do it then? It should also remain compatible with Firefox 36. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262

[issue23262] webbrowser module broken with Firefox 36+

Serhiy Storchaka added the comment: Details: https://bugzilla.mozilla.org/show_bug.cgi?id=1080319 -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___

[issue23262] webbrowser module broken with Firefox 36+

Stephan Sokolow added the comment: Well, then the code which chooses a backend is broken because I have xdg-open and, according to WinPdb, it's using the Mozilla backend. This was my local workaround: if os.name == 'posix' and not platform.mac_ver()[0]: with open(os.devnull, 'wb')

[issue23262] webbrowser module broken with Firefox 36+

Antoine Pitrou added the comment: Well, then the code which chooses a backend is broken because I have xdg-open and, according to WinPdb, it's using the Mozilla backend. You have xdg-open under Windows? -- ___ Python tracker rep...@bugs.python.org

[issue23262] webbrowser module broken with Firefox 36+

Antoine Pitrou added the comment: Oops, sorry. The best way forward would be for you to investigate and find out why xdg-open isn't preferred in your setting. -- versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org

[issue23262] webbrowser module broken with Firefox 36+

Stephan Sokolow added the comment: WinPdb = Windowed Pdb, not MS Windows Pdb. `sudo apt-get install winpdb` -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23262 ___

[issue23262] webbrowser module broken with Firefox 36+

Stephan Sokolow added the comment: Noted. I'm not sure what my schedule will be like, but I'll try. (I may get back to you with an answer later today or I may not within the week.) -- ___ Python tracker rep...@bugs.python.org

[issue23262] webbrowser module broken with Firefox 36+

Stephan Sokolow added the comment: The proper solution is to prefer `start` (Windows), `open` (OSX), or `xdg-open` (everything else... usually but not always present) when present instead of calling the browser directly. That way, you're using the same delegate to the desktop's associations

[issue23262] webbrowser module broken with Firefox 36+

Antoine Pitrou added the comment: That doesn't really answer the question. The webbrowser module is already able to use xdg-open (though not open), but it has a fallback on various concrete browsers (including Firefox) in case xdg-open doesn't work / doesn't exist. --

[issue23262] webbrowser module broken with Firefox 36+

New submission from Stephan Sokolow: As of Firefox 36 (currently in beta channel), the -remote option has been removed. https://www.mozilla.org/en-US/firefox/36.0a2/auroranotes/ https://www.mozilla.org/en-US/firefox/36.0beta/releasenotes/ As such, attempting to open http://www.example.com/