[issue23300] An improper change in httplib.py

2015-01-22 Thread Guohua Ouyang
New submission from Guohua Ouyang: Following the issue 7776, there is a patch for 2.7 version. Which changes the method of class HTTPConnection from _set_hostport to _get_hostport[1], it seems introduce in some incompatibility issues. On my system, the file

[issue23300] An improper change in httplib.py

2015-01-22 Thread Brett Cannon
Brett Cannon added the comment: That leading underscore in the method name means it is not a public API and thus changes are allowed without any backwards-compatibility guarantees. Mercurial will need to update their code to handle this if they want to continue to use the method. --

[issue23300] An improper change in httplib.py

2015-01-22 Thread Mark Lawrence
Mark Lawrence added the comment: This is a bug first reported here https://mail.python.org/pipermail/python-list/2015-January/697228.html. The problem is that in #7776 r90728 568041fd8090 _set_hostport was renamed to _get_hostport but there is still a call to the former at line 1132 in

[issue23300] An improper change in httplib.py

2015-01-22 Thread Benjamin Peterson
Benjamin Peterson added the comment: There's definitely a bug because httplib is now using a method that doesn't exist. -- nosy: +benjamin.peterson, orsenthil resolution: wont fix - status: closed - open ___ Python tracker rep...@bugs.python.org