[issue23411] Update urllib.parse.__all__

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue23411] Update urllib.parse.__all__

Roundup Robot added the comment: New changeset a48e76252952 by Serhiy Storchaka in branch 'default': Issue #23411: Added DefragResult, ParseResult, SplitResult, DefragResultBytes, https://hg.python.org/cpython/rev/a48e76252952 -- nosy: +python-dev ___

[issue23411] Update urllib.parse.__all__

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mai

[issue23411] Update urllib.parse.__all__

Serhiy Storchaka added the comment: I think it would be safer not commit this patch in 3.4 and 2.7. The patch LGTM. -- ___ Python tracker ___

[issue23411] Update urllib.parse.__all__

Martin Panter added the comment: urllib.parse-all.v2.patch removes indentation from a blank line and merges recent changes to avoid a potential conflict. -- Added file: http://bugs.python.org/file38751/urllib.parse-all.v2.patch ___ Python tracker

[issue23411] Update urllib.parse.__all__

Berker Peksag added the comment: *Result and *ResultBytes classes are documented at https://docs.python.org/3/library/urllib.parse.html#urllib.parse.DefragResult +1 for adding them to __all__. -- nosy: +berker.peksag ___ Python tracker

[issue23411] Update urllib.parse.__all__

Serhiy Storchaka added the comment: These classes were introduced by Fred in issue624325. Is it intentional that they were not added to __all__ Fred? -- nosy: +fdrake ___ Python tracker ___

[issue23411] Update urllib.parse.__all__

Martin Panter added the comment: For what it’s worth, I have used the the SplitResult class directly to build URLs from components, and to get at the hostname:port parsing functionality, as described in Issue 23416. As well as pydoc, I notice when things are missing from __all__ when I try to

[issue23411] Update urllib.parse.__all__

Serhiy Storchaka added the comment: Exposed classes are the types of results returned by urllib.parse functions. It is very unlikely that they will be directly used by the user. I see the only benefit of adding these class to __all__ that they will become visible for pydoc. Is it worth to appl

[issue23411] Update urllib.parse.__all__

Changes by Serhiy Storchaka : -- versions: +Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23411] Update urllib.parse.__all__

Senthil Kumaran added the comment: Thanks for the tests. Reviewed the patch and looks good to me. -- nosy: +orsenthil stage: -> commit review ___ Python tracker ___

[issue23411] Update urllib.parse.__all__

Changes by Martin Panter : Removed file: http://bugs.python.org/file38044/urllib.parse-all.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue23411] Update urllib.parse.__all__

Changes by Martin Panter : Added file: http://bugs.python.org/file38045/urllib.parse-all.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue23411] Update urllib.parse.__all__

New submission from Martin Panter: +"DefragResult", "ParseResult", "SplitResult", +"DefragResultBytes", "ParseResultBytes", "SplitResultBytes"] Also adds test case. -- components: Library (Lib) files: urllib.parse-all.patch keywords: patch messages: 235556 nosy: vadmium priority: normal