[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Roundup Robot added the comment: New changeset 1291649f38df by Victor Stinner in branch 'default': Issue #23646: Fix test_threading on Windows https://hg.python.org/cpython/rev/1291649f38df -- ___ Python tracker __

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Roundup Robot added the comment: New changeset 9882cc2efd36 by Victor Stinner in branch 'default': Issue #23646: Enhance precision of time.sleep() and socket timeout when https://hg.python.org/cpython/rev/9882cc2efd36 -- ___ Python tracker

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Roundup Robot added the comment: New changeset b1abd06465fc by Victor Stinner in branch 'default': Issue #23646: If time.sleep() is interrupted by a signal, the sleep is now https://hg.python.org/cpython/rev/b1abd06465fc -- ___ Python tracker

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

STINNER Victor added the comment: I commited sleep_eintr.patch by mistake. After this change, test_socket started to fail on Windows. I don't understand why. http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/5836/steps/test/logs/stdio =

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Roundup Robot added the comment: New changeset 4accc35cbfcf by Victor Stinner in branch 'default': Revert changeset d927047b1d8eb87738676980a24930d053ba2150 https://hg.python.org/cpython/rev/4accc35cbfcf -- nosy: +python-dev ___ Python tracker

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

STINNER Victor added the comment: Le jeudi 12 mars 2015, Charles-François Natali a écrit : > > As for the change to select/poll/etc, IIRC Guido was opposed to it, > that's why I didn't update them. > Wait what? can you elaborate? I'm not aware of that. -- _

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

Charles-François Natali added the comment: As for the change to select/poll/etc, IIRC Guido was opposed to it, that's why I didn't update them. -- ___ Python tracker ___

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

STINNER Victor added the comment: Note: test_signal will have to be modified again when select will also retry on EINTR :-) See issue #23485. For example, test_signal.test_wakeup_fd_early() can register a signal handler which raises an exception and catch InterruptedError. --

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

STINNER Victor added the comment: Oh, test_signal fails with the patch because time.sleep() is not interrupted by a signal. New patch. I also reverted #ifdef order in floatsleep() to have a patch easier to review. -- Added file: http://bugs.python.org/file38457/sleep_eintr-2.patch ___

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

New submission from STINNER Victor: Attached patch changes time.sleep() to retry select() when select() is interrupted by a signal or retry WaitForSingleObjectEx() when the signal SIGINT is received on Windows. The patch drops support for EMX, sorry! I didn't know EMX, I had to Google it: "EM

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

STINNER Victor added the comment: The patch includes a unit test for POSIX. For Windows, you can test manually using the attached sleep.py program: press CTRL+c to send SIGINT signals. -- Added file: http://bugs.python.org/file38455/sleep.py ___ Pyt