Steve Dower added the comment:
Updated the patch, since there's been a lot of checkins.
I also removed the pyconfig.h changes and updated the #ifdef in posixmodule.c
to enable truncate/ftruncate and define PATH_HAVE_FTRUNCATE.
And I know in the last review I said I'd switch to _Py_wopen(),
Steve Dower added the comment:
It looks like mmap uses pure Win32 APIs for the Windows implementation, and so
_chsize_s isn't necessary. There is a comment todo: need ... a 'chsize'
analog in the file, but I'm not actually sure what that means.
I've made some minor changes from the review,
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file38505/23668_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
STINNER Victor added the comment:
I reviewed 23668_2.patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
At first glance the patch looks good, but I did not test it. Are there tests
for truncate() with large files ( 4 GiB)?
ftruncate() is used also im mmap.resize(). Do you want to provide a patch also
for mmap?
--
Steve Dower added the comment:
I get a 405 error if I try and upload the patch on
http://bugs.python.org/review/23668/
My other patches from last night worked fine, so maybe Rietveld doesn't like
this issue for some reason?
--
___
Python tracker
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
___
Python-bugs-list
Steve Dower added the comment:
Hmm... doesn't even know that the issue has been changed. Reuploading with a
different extension.
--
Added file: http://bugs.python.org/file38500/23668_2.patch
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
It normally does... I'll regenerate the patch when I get a chance later today.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
Steve Dower added the comment:
Regenerated the patch file. Rietveld may not have liked that the parent
changeset in the previous patch doesn't exist (I pulled this out of my patch
queue).
--
Added file: http://bugs.python.org/file38499/23668_2.diff
Serhiy Storchaka added the comment:
Rietveld doesn't accept patches in git format.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
Changes by Steve Dower steve.do...@microsoft.com:
--
keywords: +patch
Added file: http://bugs.python.org/file38488/23668_1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23668
___
New submission from Steve Dower:
With _chsize_s (which supports 64-bit sizes, unlike _chsize), this seems fairly
trivial to do, but I'll put a patch up for it in case there's something I've
missed.
--
assignee: steve.dower
components: Windows
messages: 238113
nosy: steve.dower,
13 matches
Mail list logo