[issue23803] str.partition() is broken in 3.4

2015-04-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23803 ___

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Benjamin Peterson
Benjamin Peterson added the comment: lgtm -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23803 ___ ___ Python-bugs-list mailing list

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset c23713af8be7 by Serhiy Storchaka in branch '3.4': Issue #23803: Fixed str.partition() and str.rpartition() when a separator https://hg.python.org/cpython/rev/c23713af8be7 New changeset c48637f57e2b by Serhiy Storchaka in branch 'default': Added

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch that should fix the bug. Can it be committed in 3.3 Georg? The patch is simple and fixes a bug in basic type. -- keywords: +patch nosy: +georg.brandl stage: needs patch - patch review Added file:

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread STINNER Victor
STINNER Victor added the comment: The patch lacks unit test. You showed a test which fails also on little endian. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23803 ___

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added tests that fail on little and big endianess. -- Added file: http://bugs.python.org/file38726/str_partition_kind_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23803

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Tests added in b923eeaf8162 exposed a bug in str.partition() and str.rpartition() in 3.4 on big-endian platforms. It should exist in 3.3 too. It likely was fixed in 3.5 in issue23573.

[issue23803] str.partition() is broken in 3.4

2015-03-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The bug can be reproduced on little-endian platform. 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.partition('Ā') ('A', 'Ā', 'B\x00C\x00D\x00E\x00F\x00G\x00H\x00I\x00J\x00K\x00L\x00M\x00') 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.rpartition('Ā')