[issue23839] Clear caches after every test

Changes by Donald Stufft : -- pull_requests: +1094 ___ Python tracker ___ ___

[issue23839] Clear caches after every test

STINNER Victor added the comment: Martin Panter: """ When I run the tests with -Werror (or any other -W option), I now get 2 tests altered the execution environment: test___all__ test_warnings """ I confirm: I opened issue #28688 to track this issue (this issue is now closed). --

[issue23839] Clear caches after every test

Martin Panter added the comment: When I run the tests with -Werror (or any other -W option), I now get 2 tests altered the execution environment: test___all__ test_warnings -- nosy: +martin.panter ___ Python tracker

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: Thanks for the review Raymond. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker

[issue23839] Clear caches after every test

Roundup Robot added the comment: New changeset bc81f2137706 by Serhiy Storchaka in branch '2.7': Issue #23839: Various caches now are cleared before running every test file. https://hg.python.org/cpython/rev/bc81f2137706 New changeset 89776a40e0ec by Serhiy Storchaka in branch '3.5': Issue

[issue23839] Clear caches after every test

Raymond Hettinger added the comment: LGTM. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue23839] Clear caches after every test

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45419/regrtest_clear_caches_3.patch ___ Python tracker ___

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: Synchronized with current code and added clearing typing caches. -- Added file: http://bugs.python.org/file45413/regrtest_clear_caches_2.patch ___ Python tracker

[issue23839] Clear caches after every test

Changes by Serhiy Storchaka : -- versions: +Python 3.6 -Python 3.4 ___ Python tracker ___

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/9963/steps/test/logs/stdio Passed 395 tests of 398 and failed on test_decimal: ... [396/398] test_decimal Traceback (most recent call last): File

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: May be related: http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/10375/steps/test/logs/stdio == ERROR: testCount (test.test_socket.SendfileUsingSendfileTest)

[issue23839] Clear caches after every test

Robert Collins added the comment: Ok, so this is still in the noise space - it might be useful, it might not. Do we have reports of machines failing to run the test suite (that are also usefully big enough to compile Python and use it)? -- ___

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: I ran all tests with and without clearing all caches. Unpatched (without clearing): real31m23.694s user16m10.340s sys 2m25.084s Patched (with clearing): real29m28.859s user16m19.048s sys 1m42.184s There is no significant difference

[issue23839] Clear caches after every test

Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +patch stage: - patch review Added file: http://bugs.python.org/file38804/regrtest_clear_caches.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23839

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: We should try to know how it impacts a performance. I suppose not too much, but may be my intuition lies me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23839

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: max_rss is a little larger 500 MB after ran all testsuite (except bigmem tests) on 32-bit Linux. Only few tests needs more than 200 MB. But may be some 64-bit only tests consume more memory. If a test consume more than 1GiB of memory and is not decorated

[issue23839] Clear caches after every test

STINNER Victor added the comment: Maybe tests known to fill caches should clear theirself caches at cleanup? Always clearing all caches may have an impact on performances and so makes tests longer. Caches are designed to speedup Python :-) We may add some helper functions in test.support for

[issue23839] Clear caches after every test

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23839 ___ ___

[issue23839] Clear caches after every test

STINNER Victor added the comment: By the way, a workaround is also to run each test (file) in a new fresh process. It's a common way to work around memory fragmentation ;-) On some machines with limited resources this can cause multiple MemoryErrors. Do you have an idea of the memory usage

[issue23839] Clear caches after every test

New submission from Serhiy Storchaka: Some caches can grow unlimitedly during running the testsuite (in particular linecache). On some machines with limited resources this can cause multiple MemoryErrors. Many of these MemoryErrors can be avoided if clear caches between tests.

[issue23839] Clear caches after every test

Robert Collins added the comment: I'd like to see a definite profile of a bloated stdlib test process before we assume we know the issue - the usual leak I see in test code is used test objects, and I'm not sure we've ported the usual fix for that into unittest yet (we should). As far as

[issue23839] Clear caches after every test

Robert Collins added the comment: +1 on moving to the summary classes rather than actual tracebacks in unittest. (Or perhaps even just serialised tracebacks like we do in testtools). -- ___ Python tracker rep...@bugs.python.org