Changes by Robert Collins robe...@robertcollins.net:
--
versions: +Python 3.4, Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
___
Robert Collins added the comment:
Thanks for the patch.
--
nosy: +rbcollins
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
Roundup Robot added the comment:
New changeset 1c1c508d1b98 by Robert Collins in branch '3.4':
Issue #23888: Handle fractional time in cookie expiry. Patch by ssh.
https://hg.python.org/cpython/rev/1c1c508d1b98
New changeset 06406205ae99 by Robert Collins in branch '3.5':
Issue #23888: Handle
Demian Brecht added the comment:
LGTM, thanks for the patch!
--
nosy: +r.david.murray
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
___
ssh added the comment:
Thanks for checking in the RFC. I had done that before I posted my
StackOverflow question, but should have mentioned it here for completeness.
I've addressed the comments.
--
Added file: http://bugs.python.org/file39315/mywork.patch
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
___
___
Demian Brecht added the comment:
I left a small comment around indentation in Rietveld.
Also, for the sake of completeness (and for others taking part in this
review/commit), I dug through the relevant RFCs and none of them seem to define
time as having sub-section resolution.
--
ssh added the comment:
Wouldn't int(float(expires) * 1e6) set the date much further in the future? I'm
not sure why you'd do that unless the plan is to change the internal time unit
to microseconds (which seems like a much bigger change, and overkill for
handling this special case). Cookie
Demian Brecht added the comment:
Thanks for the follow up on that. In light of your findings, I agree with the
path you've taken in your patch (and yeah, you'd have to deal with conversions
in the output if you were to take my suggestion). I've left a couple minor
comments in Reitveld. Other
ssh added the comment:
Attaching patch after addressing comments in code review.
--
Added file: http://bugs.python.org/file39311/mywork.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
Demian Brecht added the comment:
Although it's likely not going to be a high frequency issue (but would be
painful to track down when it does become an issue), by doing an
int(float(expires)), you're losing the sub-second portion of the expiry. Why
not something like this:
try:
expires =
Demian Brecht added the comment:
Changing to behavior type as crash is generally used to indicate an
interpreter issue.
--
nosy: +orsenthil
stage: - patch review
type: crash - behavior
___
Python tracker rep...@bugs.python.org
New submission from ssh:
If the FileCookieJar reads a cookie whose expiry time is a decimal fraction, it
crashes.
Chrome extensions cookies.txt and EdiThisCookie export the expiry time as
decimal fractions. This is accepted by wget and curl, but not by the
FileCookieJar which ends up
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23888
___
___
14 matches
Mail list logo
