Steve Dower added the comment:
Was waiting for agreement or opposition, but I intended to close it within 24
hours if nothing was raised :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23995
eryksun added the comment:
Testing getpass shouldn't be that difficult if you use ctypes to call
WriteConsoleInput [1]. For example:
from ctypes import *
from ctypes.wintypes import *
kernel32 = WinDLL('kernel32')
IN, OUT, INOUT = 1, 2, 3
KEY_EVENT = 0x0001
R. David Murray added the comment:
You'll note that the problem shows up in the getpass module, which does have
tests, but which does not have a test that discovers this. That's because
writing tests that *use* these functions is not really practical :)
Someone could open an issue about
Kain added the comment:
Had the same problem but was able to fix this by rewriting the win_getpass
method in getpass.py:
def win_getpass(prompt='Password: ', stream=None):
Prompt for password with echo off, using Windows getch().
if sys.stdin is not sys.__stdin__:
return
R. David Murray added the comment:
I'm setting this to release blocker because it sounds like a simple fix and I
don't think we should release with these basic windows functions missing. If
you (Steve) don't think it is important for the beta you could set it to
deferred blocker.
--
Steve Dower added the comment:
I'll just remove the ifdefs. We don't support any Windows versions that don't
have these functions.
--
assignee: - steve.dower
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23995
Steve Dower added the comment:
Short of hard-coding a list of expected functions and using hasattr, anyone
have any ideas about how to test stuff like this? I kind of feel like
alpha/beta releases are the most efficient way to find these.
--
___
Steve Dower added the comment:
I wouldn't have thought so, since the IO stack is entirely portable, at least
from the Python side of things. This would have to have been a test that
somehow knows about optional functions and notifies you if they're missing but
without failing the run. I don't
Roundup Robot added the comment:
New changeset d56a941865fb by Steve Dower in branch 'default':
Issue #23995: Removes _WCONIO_DEFINED check as the wchar_t console functions
are always available.
https://hg.python.org/cpython/rev/d56a941865fb
--
nosy: +python-dev
Mark Lawrence added the comment:
Shouldn't tests for these functions be part of our testing of the io module or
similar?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23995
New submission from petrikas:
Python cannot access msvcrt's putwch() when using manage.py syncdb
To reproduce:
1. Call manage.py syncdb and try to create a new superuser
2. It crashes after inputting email (or before asking for the password)
Reproducible with 3.5a3, seems to be a regression
petrikas added the comment:
Edit: I am using a windows 8.1 system and django 1.8
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23995
___
___
R. David Murray added the comment:
Can you reproduce this without involving Django? That would make it more
likely that someone will have time to take a look at it.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
eryksun added the comment:
The new CRT used by 3.5 has a separate header, corecrt_wconio.h, for
declarations shared by conio.h and wchar.h. Thus the _WCONIO_DEFINED macro is
no longer defined, and consequently PC/msvcrtmodule.c skips defining getwch,
getwche, putwch, and ungetwch.
I guess
Steve Dower added the comment:
You're right, we should be able to remove the ifdef for these (or hide them
behind MS_WINDOWS if necessary).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23995
15 matches
Mail list logo
