Irit Katriel added the comment:
This function now looks like this:
PyMODINIT_FUNC
PyInit__locale(void)
{
return PyModuleDef_Init(&_localemodule);
}
--
nosy: +iritkatriel
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
Berker Peksag added the comment:
A variant of localemodule.patch without error checking for
PyModule_AddIntMacro() has been applied in
https://github.com/python/cpython/commit/ff4fddde57d5579dff3a83d99e20cd06366b10d6.
Christian, can this be closed or do we still need to add error checking
New submission from Christian Heimes:
The init function of the locale module fails to check for errors in a couple of
places. The patch replaces PyDict_SetItemString() calls with
PyModule_AddIntMacro() and error checks. An exception is unlikely so I'm OK
when the patch just lands in 3.4 and
