[issue24048] remove_module() needs to save/restore exception state

Nick Coghlan added the comment: Belatedly marking this as resolved. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24048] remove_module() needs to save/restore exception state

Zackery Spytz added the comment: It seems that Serhiy backported the fix. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24048] remove_module() needs to save/restore exception state

miss-islington added the comment: New changeset 5aa40e587e63bcad22c7e196fc3559e2b5e0792b by Miss Islington (bot) in branch '3.7': bpo-24048: Save the live exception during import.c's remove_module() (GH-13005) https://github.com/python/cpython/commit/5aa40e587e63bcad22c7e196fc3559e2b5e0792b

[issue24048] remove_module() needs to save/restore exception state

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +19765 pull_request: https://github.com/python/cpython/pull/20521 ___ Python tracker

[issue24048] remove_module() needs to save/restore exception state

Brett Cannon added the comment: Assigning to Nick to decide if he wants to backport it to 3.7 before it's no longer possible. -- assignee: -> ncoghlan ___ Python tracker

[issue24048] remove_module() needs to save/restore exception state

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24048] remove_module() needs to save/restore exception state

Zackery Spytz added the comment: I think this change should be backported. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24048] remove_module() needs to save/restore exception state

Brett Cannon added the comment: Can this be closed, Nick? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24048] remove_module() needs to save/restore exception state

Nick Coghlan added the comment: New changeset 94a64e9cd411a87514b68082c1c437eb3b49dfb9 by Nick Coghlan (Zackery Spytz) in branch 'master': bpo-24048: Save the live exception during import.c's remove_module() (GH-13005)

[issue24048] remove_module() needs to save/restore exception state

Change by Zackery Spytz : -- keywords: +patch pull_requests: +12926 stage: -> patch review ___ Python tracker ___ ___

[issue24048] remove_module() needs to save/restore exception state

Zackery Spytz added the comment: I've created a PR for this issue. -- nosy: +ZackerySpytz versions: +Python 3.7, Python 3.8 -Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue24048] remove_module() needs to save/restore exception state

Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24048 ___ ___

[issue24048] remove_module() needs to save/restore exception state

New submission from Davis Herring: import.c's remove_module() is always called with an exception set and can invoke arbitrary code via deallocation; if that code calls PyErr_Clear() (or is sensitive to PyErr_Occurred()) it will lose (or be damaged by) the preexisting exception. --