Roundup Robot added the comment:
New changeset 3eb817e19090 by Yury Selivanov in branch '3.5':
Issue 24180: Document sys.(set|get)_coroutine_wrapper
https://hg.python.org/cpython/rev/3eb817e19090
New changeset ca489c50fbd1 by Yury Selivanov in branch 'default':
Issue 24180: Document
Roundup Robot added the comment:
New changeset 8a185bb62a25 by Yury Selivanov in branch '3.5':
Issue 24180: Mention sys.(get|set)_coroutine_wrapper in whatsnew
https://hg.python.org/cpython/rev/8a185bb62a25
New changeset 10f92b4d55ed by Yury Selivanov in branch 'default':
Issue 24180: Mention
Yury Selivanov added the comment:
Closing this issue.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24180
___
Changes by Yury Selivanov yseliva...@gmail.com:
Removed file: http://bugs.python.org/file39448/async_docs_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24180
___
Changes by Yury Selivanov yseliva...@gmail.com:
Added file: http://bugs.python.org/file39449/async_docs_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24180
___
New submission from Yury Selivanov:
Please find attached a docs patch for PEP 492 changes.
I'd really appreciate if someone can review it / help me with it. I think it's
important to have at least some documentation shipped with beta-1, so that
people start testing the feature.
--
Nick Coghlan added the comment:
Patch looks worth merging to me. Some minor questions/quibbles:
Asynchronous iterator question: should the typical pattern for those be:
def __aiter__(self):
return self
def __await__(self):
return self
Did we put the ABC's in the right
Yury Selivanov added the comment:
Hi Berker, thanks for the review. I think all your edits are reasonable, so
I've just committed your patch as is.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24180
Berker Peksag added the comment:
Hi Yury,
Here is a post commit review. I've mostly removed some additional PEP 492
mentions and made a couple of trivial changes.
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file39462/issue24180.diff
Roundup Robot added the comment:
New changeset 5691d2d2d0a4 by Yury Selivanov in branch 'default':
Issue 24180: Fixes by Berker Peksag.
https://hg.python.org/cpython/rev/5691d2d2d0a4
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 548d5704fcb3 by Yury Selivanov in branch 'default':
Issue 24180: Documentation for PEP 492 changes.
https://hg.python.org/cpython/rev/548d5704fcb3
--
nosy: +python-dev
___
Python tracker
Yury Selivanov added the comment:
Thanks for the review Nick. I committed the patch with some additional minor
fixes, including your suggestion.
Asynchronous iterator question: should the typical pattern for those be:
def __aiter__(self):
return self
def __await__(self):
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: asvetlov, gvanrossum, haypo, ncoghlan, yselivanov
priority: deferred blocker
severity: normal
stage: needs patch
status: open
title: PEP 492: Documentation
type: enhancement
versions: Python 3.5
13 matches
Mail list logo