[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Serhiy Storchaka added the comment: Thank you Martin. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Antoine Pitrou added the comment: Thanks for fixing this! -- ___ Python tracker ___ ___ Python-bugs-list

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Roundup Robot added the comment: New changeset af6e8e1d15fa by Martin Panter in branch '3.5': Issue #24266: Cancel history search mode with Ctrl+C in Readline 7 https://hg.python.org/cpython/rev/af6e8e1d15fa New changeset 322d30816d36 by Martin Panter in branch 'default': Issue #24266: Merge

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: I’m getting ready to commit my patch to support the new Readline 7 function. Is there anything else to be done? The other options don’t sound worth it to me (e.g. incomplete, depending on internal details, etc). -- stage: patch review -> commit review

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Thomas Caswell added the comment: For reference https://github.com/ludwigschwardt/python-gnureadline/pull/47 is what a back-port of the functionality looks like. -- ___ Python tracker

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Thomas Caswell added the comment: I do not think that readline-cancel.patch is sufficient. The clean up function that readline uses internally (http://git.savannah.gnu.org/cgit/readline.git/tree/isearch.c#n720 ) also cleans up the context that used by isearch. The functions to cleanup the

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: Readline 7.0 alpha version includes a new “feature” that should help: i. rl_callback_sigcleanup: a new application function that can clean up and unset any state set by readline’s callback mode. Intended to be used after a signal. Patch

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

sping added the comment: I guess supporting older upstream versions would be nice in this case. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Terry J. Reedy added the comment: The patch is two lines, but I do not know our general policy for working around bugs in external modules. I do know that Idle has workarounds for tk bugs (or 'os-dependencies'). -- ___ Python tracker

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

R. David Murray added the comment: I believe that in general we do do workarounds if they don't make the code too complicated and upstream hasn't solved the problem (or we need to support older upstream versions). -- nosy: +r.david.murray ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: I reported this to Gnu Readline: https://lists.gnu.org/archive/html/bug-readline/2015-05/msg00014.html. So far it sounds like there is no general solution. I am posting a patch implementing Sebastian’s workaround. But my personal philosophy is to leave Python

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: I suspect this is actually a bug with Gnu Readline. The same issue exists in GDB. When a signal handler (such as SIGINT) raises an exception to abort the input, Python calls rl_free_line_state(). The documentation for that function,

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Martin Panter added the comment: Also applies to the interactive interpreter mode. -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Terry J. Reedy added the comment: 3.2 and 3.3 only get security fixes. I condensed the title to be visible in display boxes. It would help if you signed the PSF Contributor Agreement https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ and contributed a usable

[issue24266] raw_input + readline: Ctrl+C during search breaks readline

Serhiy Storchaka added the comment: This behavior annoyed me long time, but I had no idea how to fix this. -- nosy: +pitrou, serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266