[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Roundup Robot added the comment: New changeset 94966dfd3bd3 by Larry Hastings in branch '3.5': Issue #24305: Prevent import subsystem stack frames from being counted https://hg.python.org/cpython/rev/94966dfd3bd3 -- nosy: +python-dev ___ Python

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Nathaniel Smith added the comment: Also just checked searchcode.com, which allows more fine-grained queries, and it reports ~6500 hits for "stacklevel=2" and exactly 0 for "stacklevel=8". Huh. So the official word is that requiring stacklevel=8 on 3.4 is not a bug,

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Nathaniel Smith added the comment: Hooray! Thanks Larry. Would it make sense to do a 3.4.x backport, or is that closed now with 3.5 being imminent? -- ___ Python tracker

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Nathaniel Smith added the comment: ok -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Larry Hastings added the comment: Okay. Right now creating server-side clones is broken. So I have repurposed one of my existing (old, dead) server-side clones for testing this. It's called "ssh://h...@hg.python.org/larry/path_error2". I just fired off this change on all the "custom"

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Zachary Ware added the comment: Just to note, there's an easier way to run a custom build on multiple bots: go to http://buildbot.python.org/all/builders/ and scroll (way) down to the section for forcing a build on custom builders (you can search for 'Repo path:' (with the colon)), check the

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Larry Hastings added the comment: That *is* easier, thanks. Though the UI for that is baffling. Protip: search for the section where all the "custom" builders are listed all in one section, three-quarters of the way down the page. -- ___ Python

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Larry Hastings added the comment: Well, this is making me nervous to apply during the RCs. But... I'm willing to risk it. My price: I want to see this run on a bunch of otherwise-healthy buildbots to make sure it doesn't break any platforms. In case you've never done such a thing, here's

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Changes by Brett Cannon br...@python.org: -- assignee: larry - brett.cannon priority: deferred blocker - critical ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24305 ___

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Changes by Brett Cannon br...@python.org: Added file: http://bugs.python.org/file40286/issue24305.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24305 ___

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Brett Cannon added the comment: I figured out what was causing the threading/subprocess problems (something in frame-f_code-co-filename was NULL), so the attached patch covers Python, C, and adds a test (as well as cleaning up the test_warnings file structure since it was old-school spread

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Brett Cannon added the comment: So there are two approaches I see to solving this whole thing. One is for there to be a slight divergence between the C code and the Python code. For _warnings.warn(), nothing changes. For warnings.warn(), though, it does the expected frame skipping. This would

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

Changes by Larry Hastings la...@hastings.org: -- title: The new import system makes it impossible to correctly issue a deprecation warning for a module - The new import system makes it inconvenient to correctly issue a deprecation warning for a module