[issue24312] miniDOM._write_data() give a vague error message when the argument isn't of type str

2015-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agree with Eric. And the error message doesn't look lying. -- nosy: +serhiy.storchaka resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker _

[issue24312] miniDOM._write_data() give a vague error message when the argument isn't of type str

2015-05-28 Thread Eric V. Smith
Eric V. Smith added the comment: As a rule, we don't put in checks like this. There are an untold number of places where such checks could be added. I suspect the new typing module will be a better way to catch these types of errors. Does the problem not occur with 3.5? -- nosy: +eric

[issue24312] miniDOM._write_data() give a vague error message when the argument isn't of type str

2015-05-28 Thread Oz Tamir
Oz Tamir added the comment: I created a patch that will raise a TypeError when _write_data() has recvived an argument that is not a str. I found this exception and the error message it provide to be more straight forward and helpful when encountering this error. -- keywords: +patch Ad

[issue24312] miniDOM._write_data() give a vague error message when the argument isn't of type str

2015-05-28 Thread Oz Tamir
New submission from Oz Tamir: In Python 3.3, 3.4 and on 3.6.0a0 (default:dfe62f685538) the following snippet: >>> from xml.dom.minidom import getDOMImplementation >>> doc = getDOMImplementation().createDocument(None, 'Issues Tracker', None) >>> tracker = doc.documentElement >>> new_issue = doc.c