[issue24347] unchecked return value in C OrderedDict

2015-06-01 Thread Yury Selivanov
Changes by Yury Selivanov yseliva...@gmail.com: -- nosy: +yselivanov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24347 ___ ___ Python-bugs-list

[issue24347] unchecked return value in C OrderedDict

2015-06-01 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24347 ___

[issue24347] unchecked return value in C OrderedDict

2015-06-01 Thread Eric Snow
Eric Snow added the comment: Regarding the macros, my intent was to limit leaking the details of the linked list implementation and make it easier to change the linked list implementation later. However, if that results in problems then I'm open to changing it. What would you recommend?

[issue24347] unchecked return value in C OrderedDict

2015-06-01 Thread Eric Snow
Eric Snow added the comment: Using PyDict_GetItemWithError() is a good idea. Also, raising KeyError when the value is NULL (and no errors set) eliminates the crash. Here's a patch that fixes the problem. Unless there are any objections, I'll commit it in a couple hours. -- stage:

[issue24347] unchecked return value in C OrderedDict

2015-06-01 Thread Eric Snow
Changes by Eric Snow ericsnowcurren...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24347 ___