[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: Thanks, Joshua! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

miss-islington added the comment: New changeset 22fb674fa4c8343c84c25d93f23a1d6315d0f4f5 by Miss Islington (bot) in branch '3.7': bpo-24459: Document missing env variables in python.man (GH-4142) https://github.com/python/cpython/commit/22fb674fa4c8343c84c25d93f23a1d6315d0f4f5 --

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Change by miss-islington : -- pull_requests: +7756 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: New changeset 9863de0355caf23c44b708a5d68b603e135f7ae9 by Berker Peksag in branch 'master': bpo-24459: Document missing env variables in python.man (GH-4142) https://github.com/python/cpython/commit/9863de0355caf23c44b708a5d68b603e135f7ae9 --

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Anant Prakash added the comment: Ignore my previous comment. My bad. -- ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Anant Prakash added the comment: I am going to take the patch, edit and make a github PR for this. Any updates on this issue are welcome. Thank you -- nosy: +Anant Prakash ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Change by Berker Peksag : -- versions: -Python 3.5 ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Change by Berker Peksag : -- pull_requests: +4106 ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

STINNER Victor added the comment: > Was this ever merged? No. > I'm not sure whats happening. Hum, nothing is happening. In december, Berker wrote "Thanks for the updated patch, Joshua. I will review and commit it this week." and then it seems like he found issues, since he proposed a new

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Was this ever merged? I'm not sure whats happening. -- ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Changes by Berker Peksag : Added file: http://bugs.python.org/file46541/issue24459_cleanup_2.diff ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: Thanks for the patch and sorry for my late response. I did some tweaks and am planning to commit the tweaked version of your patch this week. -- Added file: http://bugs.python.org/file46540/issue24459_cleanup.diff

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Thanks for pointing out that wasn't in the latest patch this has been corrected. -- Added file: http://bugs.python.org/file45552/corrected.patch ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Changes by Antony Lee : -- nosy: -Antony.Lee ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Antony Lee added the comment: PYTHONUSERBASE is also missing. -- nosy: +Antony.Lee ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: Thanks for the updated patch, Joshua. I will review and commit it this week. -- versions: +Python 3.7 ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Changes by Antony Lee : -- nosy: -Antony.Lee ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Thanks for reviewing Mariatta I have made a new patch that has those typos corrected. -- Added file: http://bugs.python.org/file45045/correctedRebasedAddMissingEnvironmentalVariables.patch ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Hi I performed the rebase on the default branch. -- Added file: http://bugs.python.org/file45041/rebased_addMissingEnvironmentalVariables.patch ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Mariatta Wijaya added the comment: Hi Joshua, Seems like your latest patch doesn't apply cleanly to the default branch. Can you rebase and upload a new patch? Thanks. -- nosy: +Mariatta ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Changes by Stéphane Wirtel : -- nosy: +matrixise ___ Python tracker ___ ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: I have reviewed the comments on Rietveld and made the changes to the patch. Attached is the revised version. -- Added file: http://bugs.python.org/file43248/addMissingEnvironmentVariables-review-1.patch ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: I left some review comments on Rietveld: http://bugs.python.org/review/24459/ -- ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. -- ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Undid alphabetization and added additional missing environment variables including debug mode variables. -- Added file: http://bugs.python.org/file43166/addMissingEnvironmentVariables.patch ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: > Hi, I have alphabetized and [...] Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Joshua Jay Herman added the comment: Hi, I have alphabetized and added the missing Environment Variables according to Section 1.2 https://docs.python.org/3.6/using/cmdline.html#environment-variables . I also added the missing environment variables from that documentation section. Should

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

STINNER Victor added the comment: PYTHONASYNCIODEBUG and PYTHONTRACEMALLOC are also missing. I didn't know that Python has a manual page :-) (Misc/python.man) Note: I added these 3 environment variables ;-) -- nosy: +haypo ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

New submission from Antony Lee: The man page doesn't mention PYTHONFAULTHANDER in the list of environment variables (I haven't thoroughly checked that everyone else is there, either). I would also suggest reordering the environment variables in alphabetical order. -- assignee: