[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Jacek. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 20e2b980bb87 by Serhiy Storchaka in branch '3.4': Issue #24678: Fixed raiseExceptions typo in logging tests. https://hg.python.org/cpython/rev/20e2b980bb87 New changeset 7a54e400155f by Serhiy Storchaka in branch '3.5': Issue #24678: Fixed raiseExce

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> serhiy.storchaka stage: -> commit review type: -> behavior ___ Python tracker ___ ___

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: s/swapattr/swap_attr/g :) Done. -- Added file: http://bugs.python.org/file39968/test_logging_typo.v2.patch ___ Python tracker ___ _

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I would use test.support.swapattr(). -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-

[issue24678] raiseExceptions typo fix in logging tests

2015-07-21 Thread Jacek Kołodziej
New submission from Jacek Kołodziej: The typo in test_logging was discovered while working on #23883: in two tests the addCleanup call reverts the raiseEx*ec*ptions value (instead of raiseExceptions) in logging module and apparently that didn't manifest itself in any way. Patch attached. ---