[issue24903] Do not verify destdir argument to compileall

R. David Murray added the comment: Thanks, Jake. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue24903] Do not verify destdir argument to compileall

Roundup Robot added the comment: New changeset b63fd82a8528 by R David Murray in branch '3.4': #24903: Remove misleading error message to fix regression. https://hg.python.org/cpython/rev/b63fd82a8528 New changeset c65e135df1dc by R David Murray in branch '3.5': Merge: #24903: Remove misleading

[issue24903] Do not verify destdir argument to compileall

Changes by R. David Murray : -- stage: needs patch -> commit review ___ Python tracker ___

[issue24903] Do not verify destdir argument to compileall

Jake Garver added the comment: Updated patch. Same as before, but updates tests. Sorry I went MIA on this issue. -- Added file: http://bugs.python.org/file40440/python34_compileall_ddir_2.diff ___ Python tracker

[issue24903] Do not verify destdir argument to compileall

Jake Garver added the comment: I agree. I couldn't find a use for the check, so I removed it entirely in the provided patch. I'm running that way now with success, but of course I'm covering just one use case. Digging back a bit further, the isdir() check came in here:

[issue24903] Do not verify destdir argument to compileall

Changes by R. David Murray rdmur...@bitdance.com: -- versions: +Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24903 ___ ___

[issue24903] Do not verify destdir argument to compileall

R. David Murray added the comment: OK, so I think the goal was to prevent more than one *directory* from being specified, since as I said earlier that wouldn't make sense given we have only a single destdir path. However, for backward compatibility reasons we should probably not restrict it,

[issue24903] Do not verify destdir argument to compileall

New submission from Jake Garver: In compileall.py's main, we verify that the provided destdir (-d) exists at build time. But destdir will commonly be used to override the build time path with a runtime path. That runtime path will usually not exist at build time. Note that this logic was

[issue24903] Do not verify destdir argument to compileall

R. David Murray added the comment: That line isn't checking the existence of destdir, but rather of the (single, because we have only one destdir to use) directory to compile. What bug are you actually seeing? -- nosy: +r.david.murray ___ Python

[issue24903] Do not verify destdir argument to compileall

R. David Murray added the comment: So, given that that does something useful, it appears that the error message (which is what is in 2.7 as well) is wrong to refer to 'directory argument', and we should just eliminate the isdir check (and fix the error message). The patch will need a test.

[issue24903] Do not verify destdir argument to compileall

Jake Garver added the comment: Thanks for the response and sorry for the mis-read. In 2.7, I did something like: python -m compileall -d /runtime/path foo.py But in 3.4, I get: -d destdir requires exactly one directory argument I'm doing this during a build. Then we package the pyc file into

[issue24903] Do not verify destdir argument to compileall

R. David Murray added the comment: Actually, it looks like it is a bit more potentially complex than that. The original code would issue the error only if there were more than one argument and the first one was not a directory. So it would in fact compile more than one argument as long as