[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Change by Terry J. Reedy : -- pull_requests: -24577 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Change by miss-islington : -- pull_requests: +24577 pull_request: https://github.com/python/cpython/pull/25909 ___ Python tracker ___

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

STINNER Victor added the comment: The issue should now be fixed in 3.6, 3.7 and master branches. You will have to wait for the next release in each branch to get the fix! In the meanwhile, you can skip manually the 2to3 by modifying manually the test. Thanks for everybody who helped to

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

STINNER Victor added the comment: New changeset ba1810e1ec8973e48128e17845b981d8894c0550 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406) (GH-8407)

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

miss-islington added the comment: New changeset 1724c0c984e6406d80d8ebe3bb7b70f23c8b5f45 by Miss Islington (bot) in branch '3.6': bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406) https://github.com/python/cpython/commit/1724c0c984e6406d80d8ebe3bb7b70f23c8b5f45 -- nosy:

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Change by miss-islington : -- pull_requests: +7934 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Change by miss-islington : -- pull_requests: +7933 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

STINNER Victor added the comment: New changeset 752d4b7531093c55d6f0a5846748f981d79b29d3 by Victor Stinner in branch 'master': bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406) https://github.com/python/cpython/commit/752d4b7531093c55d6f0a5846748f981d79b29d3 --

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

STINNER Victor added the comment: Oh. I identified the root issue: Tools/scripts/2to3 is installed as Tools/scripts/2to3.py, a ".py" suffix is added. This script is tested on all non-Windows and skipped on Windows when run from source code, but test_sundry() imports 2to3.py which causes the

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Change by STINNER Victor : -- keywords: +patch pull_requests: +7932 stage: -> patch review ___ Python tracker ___ ___

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Lorenz Mende added the comment: Approving the behaviour on 3.6.5 and fresh cpython-built @master: >From the docs: test_sundry "contains extremely basic regression tests... which >don't have separate tests of their own". IMHO 2to3 can be added to the whitelist of test_sundry as it comes with

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

Terry J. Reedy added the comment: For me now, test site fails on installed 3.6.6 and 3.7.0 and passes on repository builds. Serial or parallel, no difference. When I ran as part of the suite, I got --slaveargs message. py -3.7 -m test test_tools says cannot import test tools. py -3.7 -m

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

STINNER Victor added the comment: > I had no failures on 3.4.3. How do you run the test suite? The test fails when you pass option like -j0: python -m test -j0 test_tools. IMHO the fix is trivial: monkey-patch sys.argv using support.swap_attr(sys, 'argv', ...). (I didn't try the fix).