[issue25252] Hard-coded line ending in asyncio.streams.StreamReader.readline

2015-11-27 Thread Martin Panter
Martin Panter added the comment: Eric seems to have retracted this proposal, however Issue 25752 has also been opened, which sounds very similar. -- nosy: +martin.panter status: open -> closed ___ Python tracker

[issue25252] Hard-coded line ending in asyncio.streams.StreamReader.readline

2015-09-28 Thread Eric V. Smith
Eric V. Smith added the comment: I'm closing this as unneeded. -- resolution: -> rejected stage: -> resolved ___ Python tracker ___

[issue25252] Hard-coded line ending in asyncio.streams.StreamReader.readline

2015-09-27 Thread Eric V. Smith
New submission from Eric V. Smith: A group of us (all added as nosy) spent part of the day working on issue 25008 (write an smtpd with asyncio). We came across some code that contained a copy of StreamReader.readline, but it used b'\r\n' instead of b'\n' for a line ending character. In

[issue25252] Hard-coded line ending in asyncio.streams.StreamReader.readline

2015-09-27 Thread Guido van Rossum
Guido van Rossum added the comment: Hm... Since \r\n ends with \n, what exactly would it help to pass in \r\n as the desired line ending? In either case the entire line (including the \r\n) would be returned. Unless you have a need for treating foo\nbar\r\n as a single line? (But why would

[issue25252] Hard-coded line ending in asyncio.streams.StreamReader.readline

2015-09-27 Thread Eric V. Smith
Eric V. Smith added the comment: Good point. I quick test of our sample code shows that calling regular readline to read up to '\n' does in fact work correctly. Let me do some more testing, then I'll likely close this. Thanks! -- ___ Python